Add RefreshControlDesignable example #429

tbaranes · 2017-04-02T09:13:00Z

Related to #238 and #425

A few things in this PR:

Make AnimatableTableView conforms to RefreshControlDesignable~~, iOS10 only, I think we can add a support for lower version, by adding manually the refreshControl. Is it worth it?~~
Add RefreshControlDesignable examples in playground:
- For UITableViewController.
- For UITableView

Seems big, but its mainly storyboards!

~~Just one thing: I'm getting these warnings in the console for the UITableViewController example, but don't know why 🤔~~

Failed to set (hasRefreshControl) user defined inspected property on (IBAnimatableApp.RefreshControlTableViewController): Could not load NIB in bundle: 'NSBundle <../IBAnimatableApp.app> (loaded)' with name '' Failed to set (refreshControlTintColor) user defined inspected property on (IBAnimatableApp.RefreshControlTableViewController): Could not load NIB in bundle: 'NSBundle <../IBAnimatableApp.app> (loaded)' with name '' Failed to set (refreshControlBackgroundColor) user defined inspected property on (IBAnimatableApp.RefreshControlTableViewController): Could not load NIB in bundle: 'NSBundle <../IBAnimatableApp.app> (loaded)' with name ''

IBAnimatableBot · 2017-04-02T09:29:08Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

phimage · 2017-04-02T13:46:45Z

For the warning I think it's because we play with the refreshControl before view loading
That's why I add in configureRefreshController

 guard !isViewLoaded else {
      return
    }

https://github.com/IBAnimatable/IBAnimatable/blob/master/IBAnimatable/RefreshControlerDesignable.swift

Adding for the previous ios version is welcome 👍
I want to work on that later, because I want to add support to collection too.

tbaranes · 2017-04-02T13:51:39Z

Wups, I miss this. You are right the warning has been fixed by putting back the guard, good catch! Thanks

tbaranes · 2017-04-02T14:13:55Z

Added support of AnimatableTableView RefreshControlDesignable for iOS version inferior to 10.

There's still a restriction: the user has to add himself the refresh control to its tableView, then call the configureRefreshControls (such as in the example). That make the usage harder, and ask for more code than the iOS10 version. Still, I choose this because I think it would have been even more complicated to ask the user to search its refreshControl in the tableView's subviews in order to add a target.

What do you prefer? I'm ok to change, and I will update the docs following the final decision

JakeLin

@tbaranes it is very good to support refresh control for pre-iOS 10. I have an idea: Can you add it automatically for pre-iOS 10? If we can't, I think we need to add the example code to AnimatableTableView as a comment.

Apart from that, all good 👍, well done 💪

JakeLin · 2017-04-02T22:20:55Z

CHANGELOG.md

@@ -16,8 +16,8 @@ All notable changes to this project will be documented in this file.
 [#403](https://github.com/IBAnimatable/IBAnimatable/pull/403) by [@tbaranes](https://github.com/tbaranes)
 - Make images of `AnimatableSlider` designable.
 [#417](https://github.com/IBAnimatable/IBAnimatable/pull/417) by [@phimage](https://github.com/phimage)
- Add `AnimatableTableViewController` to support `UIRefreshControl` customization.
-[#418](https://github.com/IBAnimatable/IBAnimatable/pull/418) by [@phimage](https://github.com/phimage)
+- Add `RefreshControlDesignable` to make `UIRefreshControl` customization available in interface builder. Currently supported by `UITableViewController` and `UITableView`


Interface Builder 😅

JakeLin · 2017-04-02T22:26:40Z

IBAnimatableApp/RefreshControlTableViewController.swift


  override public func viewDidLoad() {
    super.viewDidLoad()

    // Install action on refresh
-    self.refreshControl?.addTarget(self, action: #selector(RefreshTableViewController.refresh(_:)), for: .valueChanged)
+    self.refreshControl?.addTarget(self, action: #selector(refresh(_:)), for: .valueChanged)


Remove self here?

JakeLin · 2017-04-02T22:27:47Z

IBAnimatableApp/RefreshControlTableViewController.swift

      attributes[NSForegroundColorAttributeName] = color
    }
    refreshControl.attributedTitle = NSAttributedString(string: "\(Int(time))", attributes: attributes )

-    DispatchQueue.main.after(1) { [unowned self] in
-      self.updateMessage(refreshControl: refreshControl, time: time - 1)
+    DispatchQueue.main.after(1) { [weak self] in


I don't think we need to use [weak self] or [unowned self] for DispatchQueue.main. They are static methods.

JakeLin · 2017-04-02T22:30:33Z

IBAnimatable/RefreshControlerDesignable.swift

    } else {
-      refreshControl = nil
+      var refreshControl = self.subviews.first { $0 is UIRefreshControl } as? UIRefreshControl


Can we do this automatically? For example, we check there is a UIRefreshControl or not. Add one if not.

We can, see my answer below!

JakeLin · 2017-04-02T22:31:55Z

IBAnimatableApp/RefreshControlTableViewViewController.swift

+    } else {
+      refreshControl = UIRefreshControl()
+      tableView.addSubview(refreshControl!)
+      tableView.configureRefreshController()


I made a comment on https://github.com/IBAnimatable/IBAnimatable/pull/429/files#diff-f56d938957f5c1840f24beee6993086fR43

If we can't do it automatically, we may need to put this code to AnimatableTableView as a comment for pre-iOS 10.

tbaranes · 2017-04-03T06:23:36Z

@JakeLin We can add it automatically, but that means when the user will add a target, he will have to look into IBAnimatable to see how to get it then bind it. The example RefreshControlTableViewViewController (yeah, that's a big name 😃) is working for both case, iOS10 and pre-10. Just need to update the documentation following our final decision.

What do you prefer? Should I still add it automatically?

JakeLin · 2017-04-04T04:47:40Z

@tbaranes I think what you are doing is good. Please merge it when you think it is ready.

JakeLin approved these changes Apr 2, 2017

View reviewed changes

tbaranes added 8 commits April 4, 2017 08:27

Make AnimatableView conforms to RefreshControlDesignable

6425545

Add refresh control example for UITableViewController

1fb0cd0

ADd RefreshControlTableViewViewController example

d8742ab

Update CHANGELOG

d94ac06

Fix swiftlint warnings

12db355

Don’t configure refreshControl if the controller has not been loaded

8dec595

Add UITableView refreshControl support for iOS10-

7057c1f

JakeLin’s feedbacks

40424d9

tbaranes force-pushed the feature/refresh_control_example branch from 781901d to 40424d9 Compare April 4, 2017 06:27

Add notes for pre-iOS10 usage

001e3e4

tbaranes merged commit d445b4a into master Apr 4, 2017

tbaranes deleted the feature/refresh_control_example branch April 4, 2017 06:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RefreshControlDesignable example #429

Add RefreshControlDesignable example #429

tbaranes commented Apr 2, 2017 •

edited

IBAnimatableBot commented Apr 2, 2017 •

edited

phimage commented Apr 2, 2017 •

edited

tbaranes commented Apr 2, 2017 •

edited

tbaranes commented Apr 2, 2017 •

edited

JakeLin left a comment

JakeLin Apr 2, 2017

tbaranes Apr 3, 2017

JakeLin Apr 2, 2017

JakeLin Apr 2, 2017

JakeLin Apr 2, 2017

tbaranes Apr 3, 2017 •

edited

JakeLin Apr 2, 2017

tbaranes commented Apr 3, 2017

JakeLin commented Apr 4, 2017

Navigation Menu

Add RefreshControlDesignable example #429

Add RefreshControlDesignable example #429

Conversation

tbaranes commented Apr 2, 2017 • edited

IBAnimatableBot commented Apr 2, 2017 • edited

phimage commented Apr 2, 2017 • edited

tbaranes commented Apr 2, 2017 • edited

tbaranes commented Apr 2, 2017 • edited

JakeLin left a comment

Choose a reason for hiding this comment

JakeLin Apr 2, 2017

Choose a reason for hiding this comment

tbaranes Apr 3, 2017

Choose a reason for hiding this comment

JakeLin Apr 2, 2017

Choose a reason for hiding this comment

JakeLin Apr 2, 2017

Choose a reason for hiding this comment

JakeLin Apr 2, 2017

Choose a reason for hiding this comment

tbaranes Apr 3, 2017 • edited

Choose a reason for hiding this comment

JakeLin Apr 2, 2017

Choose a reason for hiding this comment

tbaranes commented Apr 3, 2017

JakeLin commented Apr 4, 2017

tbaranes commented Apr 2, 2017 •

edited

IBAnimatableBot commented Apr 2, 2017 •

edited

phimage commented Apr 2, 2017 •

edited

tbaranes commented Apr 2, 2017 •

edited

tbaranes commented Apr 2, 2017 •

edited

tbaranes Apr 3, 2017 •

edited