New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

`stickOrMoveUp` keyboard translation option #489

Merged
merged 2 commits into from May 23, 2017

Conversation

Projects
None yet
3 participants
@tbaranes
Member

tbaranes commented May 22, 2017

Any idea for a better name? I don't really like this one 馃槥
The gif is missing, will do it later

@JakeLin

The effect looks very good 馃憤馃憤馃憤. I am not good at naming and can't figure out a better one. May ask the others whether we can find a better one.

Show outdated Hide outdated CHANGELOG.md
@@ -45,7 +45,7 @@ final class PresentingViewController: AnimatableViewController, UIPickerViewData
fileprivate let animations = ["None", "Flip", "CrossDissolve", "Cover(Left)", "Cover(Right)", "Cover(Top)", "Cover(Bottom)", "Zoom", "DropDown"]
fileprivate let positions = ["Center", "TopCenter", "BottomCenter", "LeftCenter", "RightCenter"]
fileprivate let sizes = ["Half", "Full", "custom(100)"]
fileprivate let keyboardTranslations = ["None", "MoveUp", "AboveKeyboard"]
fileprivate let keyboardTranslations = ["None", "MoveUp", "AboveKeyboard", "stickOrMoveUp"]

This comment has been minimized.

@SD10

SD10 May 22, 2017

Member

Are these meant to have mismatching casing?

@SD10

SD10 May 22, 2017

Member

Are these meant to have mismatching casing?

This comment has been minimized.

@tbaranes

tbaranes May 22, 2017

Member

We accept both. So I didn't really look at it, it may be better to keep the right syntax in order to avoid bad usage

@tbaranes

tbaranes May 22, 2017

Member

We accept both. So I didn't really look at it, it may be better to keep the right syntax in order to avoid bad usage

This comment has been minimized.

@SD10

SD10 May 22, 2017

Member

Yeah I just checked out IBEnum. Not a big deal. I see more mismatching casing in the file. If anything this demonstrates that we accept both formats.

@SD10

SD10 May 22, 2017

Member

Yeah I just checked out IBEnum. Not a big deal. I see more mismatching casing in the file. If anything this demonstrates that we accept both formats.

@SD10

This comment has been minimized.

Show comment
Hide comment
@SD10

SD10 May 22, 2017

Member

I can't really think of a better name than stickOrMoveUp either.
Everything I try to think of is far worse and lacks clarity.
It almost seems like it should be the default behavior of .aboveKeyboard.

Member

SD10 commented May 22, 2017

I can't really think of a better name than stickOrMoveUp either.
Everything I try to think of is far worse and lacks clarity.
It almost seems like it should be the default behavior of .aboveKeyboard.

Tom Baranes added some commits May 22, 2017

@tbaranes

This comment has been minimized.

Show comment
Hide comment
@tbaranes

tbaranes May 23, 2017

Member

I thought about this too @SD10, but I have the feeling it's not explicit enough as well (and introducing breaking change 馃槵 ). Well, we can stick with that for now, and update later if someone comes up with a better idea!

Member

tbaranes commented May 23, 2017

I thought about this too @SD10, but I have the feeling it's not explicit enough as well (and introducing breaking change 馃槵 ). Well, we can stick with that for now, and update later if someone comes up with a better idea!

@tbaranes tbaranes merged commit 46d926c into master May 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tbaranes tbaranes deleted the feature/presentingkeyboard_up branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment