New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlaceholderDesignable & update Demo for PaddingDesignable changes #499

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
4 participants
@SD10
Member

SD10 commented Jun 12, 2017

###Summary of Pull Request:

One of my commits in #492 cleared the values in IB for PaddingDesignable this updates the Demo app to replace them.

This led me to find that PlaceholderDesignable for UITextField was using the value from placeholderText (which defaults to an empty String) before checking the actual placeholder property.

This resulted in an empty placeholder always being applied if you specified a placeholderColor.

@IBAnimatableBot

This comment has been minimized.

Show comment
Hide comment
@IBAnimatableBot

IBAnimatableBot Jun 12, 2017

1 Warning
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

Generated by 🚫 Danger

IBAnimatableBot commented Jun 12, 2017

1 Warning
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

Generated by 🚫 Danger

@tbaranes

We should definitely drop this designable property 😑

@JakeLin

👍

@SD10 SD10 merged commit 00987f9 into master Jun 13, 2017

2 of 4 checks passed

buddybuild: IBAnimatable (iOS, IBAnimatable) Build error
Details
buddybuild: IBAnimatable (iOS, IBAnimatableApp) Build error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@SD10 SD10 deleted the fix/app-padding-designable branch Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment