New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BackgroundDesignable corruption of UIKit #506

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@SD10
Member

SD10 commented Jul 7, 2017

Summary of Pull Request:

Removes direct extensions to UIKit classes using BackgroundDesignable.
Instead, I made BackgroundImageDesignable conform to BackgroundDesignable.
This is not the usual approach we take for designable protocols, but to remove this protocol I would have to repeat the same code 3+ times.

Should fix #505. It seems like if you extend a UIKit class it can cause Interface Builder to stop recognizing the IBOutlets for that class.

@tbaranes

CHANGELOG entry missing
Thanks for taking care of this weird issue!

@SD10 SD10 merged commit 97c3b7d into master Jul 7, 2017

5 checks passed

buddybuild: IBAnimatable (iOS, IBAnimatable) Build succeeded
Details
buddybuild: IBAnimatable (iOS, IBAnimatableApp) Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
danger/danger All green. Congrats.

@SD10 SD10 deleted the bugfix/border-designable-corruption branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment