New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more values for `PresentationModalSize` #512

Merged
merged 4 commits into from Sep 19, 2017

Conversation

Projects
None yet
3 participants
@phimage
Member

phimage commented Sep 17, 2017

some proportional sizes added to enum

PS: I can wait swift 4 branch merging

TODO

  • CHANGELOG

phimage added some commits Sep 17, 2017

Doc and changelog for new modal size ratio
Fix swiftlint warnings
@phimage

This comment has been minimized.

Show comment
Hide comment
@phimage

phimage Sep 17, 2017

Member

alternative implementation
Have one enum with name XXX (maybe ratio)
For size, return screen size divided by the ratio
But keep in init with String, keep all String cases and create the new enum for each

Member

phimage commented Sep 17, 2017

alternative implementation
Have one enum with name XXX (maybe ratio)
For size, return screen size divided by the ratio
But keep in init with String, keep all String cases and create the new enum for each

@JakeLin

I like those enums. It should cover most of the cases. Especially comes with GoldenRatio 😉. Shall we merge it after we bring swift4 branch in?

@phimage

This comment has been minimized.

Show comment
Hide comment
@phimage

phimage Sep 18, 2017

Member

You can merge when you want. I can make a new PR if too much conflict.

Member

phimage commented Sep 18, 2017

You can merge when you want. I can make a new PR if too much conflict.

JakeLin added some commits Sep 19, 2017

@SD10

SD10 approved these changes Sep 19, 2017

Great work @phimage 💯 Travis finally completed 😅

@JakeLin JakeLin merged commit 84fe96c into master Sep 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@JakeLin JakeLin deleted the feature-presentationsizes branch Sep 19, 2017

@JakeLin

This comment has been minimized.

Show comment
Hide comment
@JakeLin

JakeLin Sep 19, 2017

Member

thanks @phimage we are ready for version 5

Member

JakeLin commented Sep 19, 2017

thanks @phimage we are ready for version 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment