Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Handle multiple attachments of the same image #34

Closed
IBBoard opened this issue Sep 28, 2019 · 0 comments
Closed

Handle multiple attachments of the same image #34

IBBoard opened this issue Sep 28, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@IBBoard
Copy link
Owner

IBBoard commented Sep 28, 2019

Currently, if you attach the same image twice then the ComposeImageManager.set_image_progress () function uses (btn.image_path == image_path) to check when it has found the right button and so always hits the first image and updates the status of that.

Twitter allows multiple copies of the same image (and the upload works through Cawbird, if you ignore the incorrect UI feedback). This means that ComposeJob.image_upload_progress needs reworking so that it doesn't just use the local path.
@IBBoard IBBoard added the bug Something isn't working label Sep 28, 2019
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #34: Reference uploads by internal UUID
dde7037 
We can now differentiate between duplicate images and
update the correct status.

Fixes #34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IBBoard