This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
UI updates from InterConnect #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2fprod
reviewed
Mar 28, 2017
src/modules/demos.js
Outdated
| @@ -176,6 +184,7 @@ export function *watchEndDemoSession() { | |||
| yield take(END_DEMO_SESSION); | |||
| const demoState = yield select(demoSelector); | |||
| try { | |||
| yield put(logoutSuccess()); | |||
There was a problem hiding this comment.
should logoutSuccess() comes after the code to the backend API succeed?
| @@ -39,7 +40,14 @@ const ForecastTile = ({ weather }) => { | |||
| <TableRow key={i}> | |||
| <TableRowColumn style={styles.column}>{forecast.dow}</TableRowColumn> | |||
| <TableRowColumn style={styles.column}> | |||
| <img | |||
There was a problem hiding this comment.
nice that we have icons here now. Can you add it to the ShipmentCard too for consistency?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.