New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTTPServerRequest.url in a better way #112

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
2 participants
@pushkarnk
Copy link
Contributor

pushkarnk commented Nov 21, 2018

The url property on HTTPServerRequest.url, which if of type Data, is the Data representation of the URI which includes the path and the query parameters starting with URI. This is available in HTTPRequestHead as a String, which could be simply accessed and converted to Data. This change leads to a performance improvement of ~3%.

Implement HTTPServerRequest.url in a better way
The url property on HTTPServerRequest.url, which if of type Data, is the Data representation of the URI which includes the path and the query parameters starting with URI. This is available in HTTPRequestHead as a String, which could be simply accessed and converted to Data. This change leads to a performance improvement of ~3%.
@nethraravindran
Copy link
Contributor

nethraravindran left a comment

LGTM

@pushkarnk pushkarnk merged commit ebdaee3 into IBM-Swift:master Nov 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment