Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
FileResourceServer must be explicitly enabled when initializing Router #1344
This is a redo of #1343 based on feedback in that thread. Whereas the code in that PR implicitly disabled the FileResourceServer for a Router if that Router had any elements/handlers, this PR changes Router to add a new optional
Motivation and Context
@djones6 recommended this approach rather than the one I had chosen in the original PR, and I like his idea better than mine too. As stated there, this may break expected functionality with the Kitura CLI tool.
How Has This Been Tested?
As with the other PR, existing tests testing the FileResourceServer functionality have been tweaked, and a new test has been added to ensure the functionality is not present by default.