fix: Updating to swift 4 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnriqueL8
force-pushed
the
update_swift4
branch
from
dafad09
to
4f6df4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
========================================
Coverage ? 70.8%
========================================
Files ? 4
Lines ? 274
Branches ? 0
========================================
Hits ? 194
Misses ? 80
Partials ? 0
Continue to review full report at Codecov.
|
EnriqueL8
changed the title
djones6
suggested changes
Mar 21, 2018
.swift-version
Outdated
| @@ -1 +1 @@ | |||
| 3.1 | |||
| 4.0 | |||
|
|
||
| script: | ||
| - ./build.sh | ||
| - ./Package-Builder/build-package.sh -projectDir $TRAVIS_BUILD_DIR |
There was a problem hiding this comment.
I understand the only difference between build.sh and invoking build-package.sh directly was in the Docker case, and we've already removed the docker build, so this seems okay.
.travis.yml
Outdated
| env: SWIFT_SNAPSHOT=$SWIFT_4_DEV_SNAPSHOT | ||
| - os: osx | ||
| osx_image: xcode8.3 | ||
| sudo: required | ||
| - os: osx | ||
| osx_image: xcode9 |
There was a problem hiding this comment.
You should be able to use xcode9.2 with Swift 4.0.3
djones6
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.