This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixing bug with String deserialization where Strings weren't properly… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besawn
reviewed
May 1, 2018
|
@besawn No, because we don't perform a malloc on fixed strings and as such no free occurs on them. The problem with regular strings was the free was hitting uninitialized strings and attempting the free resulting in the segmentation fault. |
|
Talked with @besawn, I think it's appropriate to make a story working on a regression/unit test for the serialization engine to cover future segmentation faults. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… nulled.
Fixing a defect were bad buffers result in a segmentation fault due to improper string initialization.