Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Utils #13

Merged
merged 69 commits into from Jul 11, 2019
Merged

Image Utils #13

merged 69 commits into from Jul 11, 2019

Conversation

kmh4321
Copy link
Contributor

@kmh4321 kmh4321 commented Mar 14, 2019

Fixes #8.

maxfw/utils/test_image_utils.py and maxfw/utils/test_image.png are temporary files for testing purposes and can be deleted when the PR is approved.

Karthik Muthuraman and others added 20 commits February 28, 2019 16:23
Initial commit
c6eaddd
@kmh4321
initial commit.
629e5ca
@splovyt
Add backbone for image_utils module. Also updated the setup.py file w…
b695d1e 
…ith the Pillow dependency.
@kmh4321
Merge pull request #1 from splovyt/master
594d3ea 
Proposed backbone of the image_utils module.
@kmh4321
Added basic image pre processing utils.
4549e48
@kmh4321
Added postprocessor code.
7cc00b8
@kmh4321
added test image and code. modularized preprocessing.
12354f8
@kmh4321
Changed variable names to avoid confusion.
25b622e
@kmh4321
Fixed postprocessing code.
e92763e
@splovyt
Rename test_temp.py and add pytest, add verbosity support, and reformat
7e0939b
@kmh4321
Merge pull request #2 from splovyt/splovyt_image_utils
a253f43 
Rename test_temp.py and add pytest, add verbosity support, and reformat
@kmh4321
Added functions for converting dtype and standardize/normalize.
f1faad5
@splovyt
Switch to ABC structure, implement sanity checks, implement more tran…
e15bde3 
…sformations, and add some tests
@kmh4321
Merge pull request #3 from splovyt/image_utils
e59868b 
[WIP] Switch to ABC structure, implement sanity checks, implement more transformations, and add some tests
@splovyt
Update dimension checks, and add denormalization
a4b8d0e
@splovyt
add documentation
ef0e9ab
@kmh4321
Merge pull request #4 from splovyt/image_utils2
126f51b 
Added resizing functions, documentation, and denormalization function
@kmh4321
rearranged functions and other cosmetic changes.
c005207
@kmh4321
Fixed function signature in test script.
2f18f54
@kmh4321
Fixed issues from unit testing.
0b666b4
@kmh4321 kmh4321 added the enhancement New feature or request label Mar 14, 2019
@kmh4321 kmh4321 self-assigned this Mar 14, 2019
@kmh4321 kmh4321 requested a review from djalova March 14, 2019 21:01
bdwyer2
bdwyer2 reviewed Mar 14, 2019
View reviewed changes
maxfw/utils/image_utils.py Outdated Show resolved Hide resolved
bdwyer2
bdwyer2 reviewed Mar 14, 2019
View reviewed changes
Copy link

@bdwyer2 bdwyer2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add an __init__.py to the maxfw folder then set travis to run the test script?

maxfw/utils/test_image_utils.py Outdated Show resolved Hide resolved
bdwyer2 and others added 2 commits March 14, 2019 16:08
@bdwyer2 @kmh4321
fixed typo.
6814c0f 
Co-Authored-By: kmh4321 <kmh4321@gmail.com>
@kmh4321
Updated test scripts.
fbedd6c
@splovyt splovyt self-requested a review March 15, 2019 00:23
xuhdev
xuhdev reviewed Jun 21, 2019
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
xuhdev
xuhdev reviewed Jun 21, 2019
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@kmh4321
Merge pull request #8 from splovyt/june20
b031be2 
06/20 - update to the image_utils branch
xuhdev
xuhdev reviewed Jun 21, 2019
View reviewed changes
maxfw/core/utils.py Outdated Show resolved Hide resolved
@splovyt
Copy link
Contributor

splovyt commented Jun 24, 2019

I resolved most issues, and have added an initial version of the extended standardize functionality. @kmh4321 can you briefly review the standardize function and tests before pass the ball back to Nick? Thanks

@kmh4321 kmh4321 requested a review from MLnick June 26, 2019 20:32
MLnick
MLnick reviewed Jul 2, 2019
View reviewed changes
Copy link

@MLnick MLnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good - a few comments on tests and on the redirect errors fn.

maxfw/tests/test_image_utils.py Outdated Show resolved Hide resolved
maxfw/tests/test_image_utils.py Outdated Show resolved Hide resolved
maxfw/tests/test_image_utils.py Show resolved Hide resolved
maxfw/core/utils.py Show resolved Hide resolved
xuhdev
xuhdev reviewed Jul 2, 2019
View reviewed changes
maxfw/core/utils.py Outdated Show resolved Hide resolved
MLnick
MLnick reviewed Jul 4, 2019
View reviewed changes
maxfw/tests/test_image_utils.py Outdated Show resolved Hide resolved
maxfw/utils/image_functions.py Show resolved Hide resolved
maxfw/core/utils.py Outdated Show resolved Hide resolved
maxfw/core/utils.py Outdated Show resolved Hide resolved
@kmh4321 kmh4321 requested a review from xuhdev July 8, 2019 23:16
MLnick
MLnick approved these changes Jul 11, 2019
View reviewed changes
Copy link

@MLnick MLnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's go ahead and merge. Before we do any maxfw release, let's do some testing on using image utils on a few models (we may uncover issues or bugs etc).

@splovyt
Copy link
Contributor

splovyt commented Jul 11, 2019

@xuhdev

xuhdev
xuhdev approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@splovyt splovyt merged commit c4f0a80 into IBM:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djalova djalova djalova left review comments

@bdwyer2 bdwyer2 bdwyer2 left review comments

@splovyt splovyt splovyt left review comments

@xuhdev xuhdev xuhdev approved these changes

@MLnick MLnick MLnick approved these changes

Assignees

@kmh4321 kmh4321

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add image utils
6 participants
@kmh4321 @djalova @splovyt @MLnick @xuhdev @bdwyer2