Regional file support

[sameshai]

No description provided.

[sameshai]

🔴 Coverage decreased from [84.7111%] to [84.1889%]

[sameshai]

🔴 Coverage decreased from [84.7111%] to [84.1889%]

[sameshai]

🔴 Coverage decreased from [84.7111%] to [84.1889%]

[arahamad]

Please check my comments and do the changes accordingly

[sameshai]

🔴 Coverage decreased from [84.7111%] to [84.3333%]

[sameshai]

🔴 Coverage decreased from [84.7111%] to [84.4667%]

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8444%]

[arahamad]

can you check my review comments and do the change accordingly

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8%]

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8%]

[sameshai]

@arahamad We can create Rfs volume of size 1Gi , 3Gi etc

sameershaikh@Sameers-MBP eni % k apply -f vpcfile-pvc.yaml 
persistentvolumeclaim/sds-max created
ameershaikh@Sameers-MBP eni % oc apply -f crossdeploy.yaml 
deployment.apps/testpodrwmcr created
sameershaikh@Sameers-MBP eni % k get pvc
NAME      STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                               VOLUMEATTRIBUTESCLASS   AGE
sds-max   Bound    pvc-3f666c07-13e0-4bdb-b571-899966a18ca4   3Gi        RWX            ibmc-vpc-file-regional-max-bandwidth-sds   <unset>                 16m


{"level":"info","ts":"2025-09-02T14:28:55.176Z","caller":"ibmcsidriver/controller.go:75","msg":"CSIControllerServer-CreateVolume... ","RequestID":"d33772c9-41a1-4099-bed3-a56d4c443f09","Request":{"name":"pvc-3f666c07-13e0-4bdb-b571-899966a18ca4","capacity_range":{"required_bytes":3221225472},"volume_capabilities":[{"AccessType":{"Mount":{"mount_flags":["hard","nfsvers=4.1","sec=sys"]}},"access_mode":{"mode":5}}],"parameters":{"billingType":"hourly","classVersion":"1","encrypted":"false","encryptionKey":"","gid":"0","isENIEnabled":"true","primaryIPAddress":"","primaryIPID":"","profile":"rfs","region":"","resourceGroup":"","securityGroupIDs":"","subnetID":"","tags":"","throughput":"8192","uid":"0","zone":""},"accessibility_requirements":{"requisite":[{"segments":{"failure-domain.beta.kubernetes.io/region":"us-south","failure-domain.beta.kubernetes.io/zone":"us-south-1"}}],"preferred":[{"segments":{"failure-domain.beta.kubernetes.io/region":"us-south","failure-domain.beta.kubernetes.io/zone":"us-south-1"}}]}}}
{"level":"info","ts":"2025-09-02T14:28:55.176Z","caller":"ibmcsidriver/controller_helper.go:215","msg":"Ignoring storage class parameter","RequestID":"d33772c9-41a1-4099-bed3-a56d4c443f09","ClassParameter":"classVersion"}
{"level":"info","ts":"2025-09-02T14:28:55.176Z","caller":"ibmcsidriver/controller_helper.go:299","msg":"Volume size in bytes","RequestID":"d33772c9-41a1-4099-bed3-a56d4c443f09","capacity":3221225472}
{"level":"info","ts":"2025-09-02T14:28:55.176Z","caller":"ibmcsidriver/controller_helper.go:305","msg":"Volume size in GiB","RequestID":"d33772c9-41a1-4099-bed3-a56d4c443f09","capacity":3}


{"level":"info","ts":"2025-09-02T14:28:59.614Z","caller":"vpcfilevolume/create_file_share.go:53","msg":"Equivalent curl command and payload details","RequestID":"d33772c9-41a1-4099-bed3-a56d4c443f09","URL":"https://us-south-stage01.private.iaasdev.cloud.ibm.com/v1/shares?generation=2&maturity=beta&version=2025-09-01","Payload":{"name":"pvc-3f666c07-13e0-4bdb-b571-899966a18ca4","size":3,"bandwidth":8192,"resource_group":{"id":"1249dd7427804689aa70ee0688a7e76d"},"profile":{"name":"rfs"},"mount_targets":[{"name":"pvc-3f666c07-13e0-4bdb-b571-899966a18ca4","transit_encryption":"none","access_protocol":"nfs4","virtual_network_interface":{"subnet":{"id":"0716-b5240ed4-11f2-4022-a8e9-4d7463067143"},"security_groups":[{"id":"r134-99a5730b-02a4-4805-bbcd-e9cfc9669bee"}],"resource_group":{"id":"1249dd7427804689aa70ee0688a7e76d"}}}],"access_control_mode":"security_group"},"Operation":{"Name":"CreateFileShare","Method":"POST","PathPattern":"/v1/shares"}}

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8%]

[arahamad]

@sameshai , Can you share the tests cases which you have validated with these changes

[sameshai]

@sameshai , Can you share the tests cases which you have validated with these changes

• DP2 PRofile min iops with 1 GB size which will default to 10GB should pass
• DP2 Profile with custom iops 500 and size 23 Gi should pass
• Bandwitdh for DP2 profile should fail.
• RFS Profile 1Gi , 3Gi , 11Gi Size should pass
• RFS with 23 Gi , 1000 mbps bandwidth and KMS encryption key should pass ( Allowlisted for encryption)
• RFS with KMS encryption key should fail ( Not Allowlisted for encryption)
• Feature flag check for RFS Profile enabled on allowlisted (pass) and non-allowlisted accounts (fail)
• RFS with with non-zero UID and GID should pass
• RFS with custom subnet-id should pass
• RFS with customSG should pass
• RFS with primaryIPID should pass
• RFS with primaryIPAddress should pass
• Iops not supported for rfs profile should fail
• Zone not supported for rfs profile should fail
• InvaliBandwidth more that 8192 for rfs profile should fail

Results : https://github.ibm.com/alchemy-containers/armada-storage/issues/8006

[arahamad]

@sameshai , Can you share the tests cases which you have validated with these changes

• DP2 PRofile min iops with 1 GB size which will default to 10GB
• Bandwitdh for DP2 profile
• RFS Profile 1Gi and 3Gi Size with default bandwidth
• Feature flag check for RFS Profile enabled on allowlisted and non-allowlisted accounts
• Iops not supported for rfs profile
• Zone not supported for rfs profile
• Invalid Bandwidth for rfs profile

Results : https://github.ibm.com/alchemy-containers/armada-storage/issues/8006

can you add expectation or results

[arahamad]

Good way to avoid VPC IaaS call with flag

• Feature flag check for RFS Profile enabled on allowlisted (pass) and non-allowlisted accounts (fail)

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8%]

[arahamad]

please check

[arahamad]

Please validate encryption as well

[sameshai]

Please validate encryption as well

Encryption requires one more level of allowlisting , we have asked them to allowlist our accounts and then we can re-test it as of now we get below error from IAAS

  Warning  ProvisioningFailed    15s                   vpc.file.csi.ibm.io_ibm-vpc-file-csi-controller-7fd8c47777-v4s76_bde8d69d-9015-415c-aa92-f1b6a2682d92  failed to provision volume with StorageClass "regional-custom-sc": rpc error: code = Internal desc = {RequestID: 3fb5ce98-4e94-43fe-98eb-00c3baecff0a , BackendError: {Trace Code:3fb5ce98-4e94-43fe-98eb-00c3baecff0a, Code:shares_not_implemented, Description:The requested operation is not implemented., RC:501 Not Implemented.Failed to create file share with the storage provider}, Action: Please check 'BackendError' tag for more details}

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8%]

[arahamad]

shares_not_implemented

looks this error code shares_not_implemented not related with encryption? can we ask VPC team that this error code is misleading or do they provide msg also along with error code? are we retrying in this case ? can we skip it

[sameshai]

shares_not_implemented

looks this error code shares_not_implemented not related with encryption? can we ask VPC team that this error code is misleading or do they provide msg also along with error code? are we retrying in this case ? can we skip it

@arahamad Already raised PR for this and we have taken care of this

https://github.com/IBM/ibmcloud-volume-file-vpc/pull/73/files

[sameshai]

👍 Coverage increased from [84.7111%] to [84.8%]

[arahamad]

@sameshai , Is this PR ready?

[sameshai]

@

@arahamad yes we ready for merge

[prankulmahajan]

lgtm

[arahamad]

lgtm