Add support for VolumeAccessPoint(FileShareTarget Creation) if volume creation fails but creates (File share) #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hare creation fails Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
sameshai
changed the title
GunaKKIBM
previously approved these changes
May 29, 2024
|
👍 Coverage increased from [%] to [82.7875%] |
|
👍 Coverage increased from [%] to [83.3%] |
…hare creation fails Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
|
👍 Coverage increased from [%] to [83%] |
…hare creation fails Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
|
👍 Coverage increased from [%] to [%] |
1 similar comment
|
👍 Coverage increased from [%] to [%] |
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
|
👍 Coverage increased from [%] to [82.875%] |
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
|
👍 Coverage increased from [%] to [82.675%] |
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
|
👍 Coverage increased from [%] to [83.3125%] |
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
GunaKKIBM
approved these changes
May 30, 2024
|
👍 Coverage increased from [%] to [83.1%] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason the File share is created but target creation fails. Lets retry creating target so that we have way to recover the file share created.
Results : https://github.ibm.com/alchemy-containers/armada-storage/issues/6106