Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an icon to notification banner/alert by argument #44

Closed
mallej opened this issue Sep 16, 2021 · 6 comments · Fixed by #68
Closed

Add an icon to notification banner/alert by argument #44

mallej opened this issue Sep 16, 2021 · 6 comments · Fixed by #68
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mallej
Copy link

mallej commented Sep 16, 2021

Is your feature request related to a problem? Please describe.
I´m switching from Yo to Mac-ibm-motifications and sorely miss the ability to include icons in notifications.

Describe the solution you'd like
The --icon argument from https://github.com/sheagcraig/yo

Additional context
as you can see in the screenshot, I used the icon function of Yo to indicate to the end user which app was installed with Munki.
Screenshot 2021-09-16 at 12 49 53
.

@SMartorelli
Copy link
Member

Hi @mallej, thanks for suggesting new features. We'll take care of it asap.

@SMartorelli SMartorelli added the enhancement New feature or request label Sep 16, 2021
@SMartorelli SMartorelli self-assigned this Sep 16, 2021
@SMartorelli SMartorelli changed the title add an icon to notification by argument Add an icon to notification banner/alert by argument Sep 16, 2021
@kylejericson
Copy link

How do you use this icon option when running as a Notification banner/alert?

@SMartorelli
Copy link
Member

Hi @kylejericson, this FR has not been implemented yet

@kylejericson
Copy link

kylejericson commented Nov 12, 2021

In the meantime, if you wanted a custom icon could you edit the Xcode project with a custom icons?

@SMartorelli
Copy link
Member

Do you mean how to change the left icon for the banner/alert? That icon is inherited from the main app icon and so only rebranding the app you can customize it. To do so read more here: https://github.com/IBM/mac-ibm-notifications/wiki/Rebranding-the-application

@kylejericson
Copy link

Thanks so much didn't see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants