Skip to content

Fix PII Detection Logic to Correctly Update modified Flag #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Fix PII Detection Logic to Correctly Update modified Flag #1496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/pii_filter/pii_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ def _process_nested_data_for_pii(self, data: Any, path: str, all_detections: dic
all_detections[path] = detections
self.detection_count += sum(len(items) for items in detections.values())
has_detections = True

modified = True
if self.pii_config.log_detections:
logger.warning(f"PII detected in tool result at '{path}': {', '.join(detections.keys())}")

Expand Down
Loading