Skip to content

Conversation

@sirijaibm
Copy link
Collaborator

@sirijaibm sirijaibm commented Sep 3, 2025

PR summary

It’s a full integration test suite for IBM Cloud RulesetsV1, covering instance and zone rulesets.

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Sirija Reddy <sirija@ibm.com>
@sirijaibm
Copy link
Collaborator Author

UTs:

>> PYTHONPATH=$(pwd) pytest test/unit/test_rulesets_v1.py
======================================================================= test session starts ========================================================================
platform darwin -- Python 3.13.5, pytest-8.4.1, pluggy-1.6.0
rootdir: /Users/sirija/Desktop/repos/public/networking-python-sdk
plugins: cov-2.12.1, rerunfailures-16.0.1
collected 153 items                                                                                                                                                

test/unit/test_rulesets_v1.py .............................................................................................................................. [ 82%]
...........................                                                                                                                                  [100%]

======================================================================= 153 passed in 0.83s ========================================================================

ITs:

>> PYTHONPATH=$(pwd) pytest test/integration/test_rulesets_v1.py                                             
======================================================================= test session starts ========================================================================
platform darwin -- Python 3.13.5, pytest-8.4.1, pluggy-1.6.0
rootdir: /Users/sirija/Desktop/repos/public/networking-python-sdk
plugins: cov-2.12.1, rerunfailures-16.0.1
collected 24 items                                                                                                                                                 

test/integration/test_rulesets_v1.py ........................                                                                                                [100%]

================================================================== 24 passed in 67.87s (0:01:07) ===================================================================

@sirijaibm sirijaibm merged commit f6247c5 into master Sep 3, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants