-
Notifications
You must be signed in to change notification settings - Fork 38
docs: Add migration guide #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kadler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first pass. Lots of good info here. In addition to the specific comments, all the "removed at a later time" should be "removed in the next major version".
|
I have added some updates, please re-review. |
|
Let's land this after #173 is done. |
|
Now that we have sphinx set up, @abmusse can you focus on getting this setup within sphinx. I think we should have a migration guide section in the nav bar and hook it in there. Also would be good to link to it from the main intro, adding some text there. |
|
I had issues getting the emoji I ended up copying UTF-8 Unicode Character 🚨 and pasting it into the migration guide. Better but does not have the styling. |
|
If we convert it to rst, we can use admonitions. Not sure if they are supported by mkdocs. |
|
Yeah converting the migration guide to |
|
@kadler I've converted the migration guide from markdown to rst |
|
@kadler This is ready for re-review |
| Migrating from ``iConn.run()`` to ``Connection.run()`` | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is way more important to highlight than the prior one. You should be able to figure out how to connect using Connection from the docs, however you may not realize that iConn -> Connection implies a change in behavior of the callbacks. I think we definitely need some WARNING messages above to point the user at this section and mention returnError.
Something like:
"Beware that the Connection and iConn classes differ in how they call the callbacks passed to their run methods. You cannot simply replace iConn with Connection without adjusting your callbacks. See here for more info on how to do that.
…guide to sphinx docs



Resolves #143