Skip to content

fix(Global Search): update service after recent API changes #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix(Global Search): update service after recent API changes #97

merged 1 commit into from
Mar 25, 2021

Conversation

@pyrooka
Copy link
Member

@pyrooka pyrooka commented Mar 25, 2021 •
edited
Loading

PR summary

This PR updates the Global Search service after recent API changes.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx March 25, 2021 14:32
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #97 (5d097ab) into main (850e9ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          21       21           
  Lines       20022    20022           
=======================================
  Hits        18738    18738           
  Misses       1284     1284
Impacted Files Coverage Δ
ibm_platform_services/global_search_v2.py 89.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850e9ad...5d097ab. Read the comment docs.

padamstx
padamstx approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 4741518 into main Mar 25, 2021
@padamstx padamstx deleted the update-gs branch March 25, 2021 16:35
ibm-devx-automation pushed a commit that referenced this pull request Mar 25, 2021
@semantic-release-bot
chore(release): 0.17.18 release notes
7678c2a 
## [0.17.18](v0.17.17...v0.17.18) (2021-03-25)

### Bug Fixes

* **Global Search:** update service after recent API changes ([#97](#97)) ([4741518](4741518))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@padamstx padamstx padamstx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pyrooka @ibm-devx-automation @padamstx