-
Notifications
You must be signed in to change notification settings - Fork 21
removed output and creds from nb #19
Conversation
sanjeevghimire
commented
Aug 23, 2019
- removed output and creds from notebook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo is back
Please fix the regression. Also see other comments, just questions that I might have ignored if it wasn't for the regression.
notebooks/WML DB2.ipynb
Outdated
| "metadata": {}, | ||
| "source": [ | ||
| "## 4c. Developing The Model with Random Forest\n", | ||
| "## 4c. Devloping The Model with Random Forest\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regression on the typo
notebooks/WML DB2.ipynb
Outdated
| "metadata": {}, | ||
| "source": [ | ||
| "## 4d. Developing The Model with Gradient Boosting\n", | ||
| "## 4d. Devloping The Model with Gradient Boosting\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
| " \"instance_id\": '<INSTANCE ID>',\n", | ||
| " \"url\": \"<URL>\"\n", | ||
| "wml_credentials = { \n", | ||
| " \"apikey\": \"<api key>\",\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a regression or you prefer lower?
| "# @hidden_cell\n", | ||
| "# idadb_fe06e3df5eef4ac0b1c246b40ed3db6e.close()\n", | ||
| "# To learn more about the ibmdby package, please read the documentation: http://pythonhosted.org/ibmdbpy/\n" | ||
| "# Connect to datasource\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if you meant to delete the "PLEASE ENTER..." comment. Your readme probably has it covered.