Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Import cluster implementation by @bsm #84

Closed
wants to merge 1 commit into from
Closed

Conversation

wvanbergen
Copy link
Contributor

This is a WIP to bring @bsm's cluster implementation to Sarama.

TODO / discussion:

  • Do we want to keep it in a separate package or merge it into the main sarama package?
  • Tests need to be rewritten to fit the rest of the library.
  • Let's use a standard UUID instead of the custom guid implementation.

/cc @eapache @burke


if evtlen < 1 {
return nil
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working for me; it is always empty because I think this is a synchronous channel in the latest Sarama release. When I remove the check, and just wait on <-events instead, it works. However, the batching doesn't really make sense anymore with that change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, on the current master (f503eb0) the consumer event channel can be buffered (and the default buffer size is 16.) The way I understand it, the len(events) check should only fail if the channel isn't buffered; unbuffered channels always have a length of 0: http://play.golang.org/p/mZ7aWiY0ax

@wvanbergen wvanbergen closed this Jun 25, 2014
@wvanbergen wvanbergen deleted the cluster branch June 25, 2014 07:58
@wvanbergen
Copy link
Contributor Author

I moved this effort to https://github.com/wvanbergen/kafka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants