This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Feature/ub 211 move build script to git #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the pvc unit is gib in yaml file, but ubiquity sent to scb with unit gb. That caused the volume size is not correct. As confirmed with SCB developer, SCB support both unit gib and gb. I just modify the unit from gb to gib in this patch.
Fix for "concurrent map writes" error causing Ubiquity restart
Changing postgresql max_connection to 1000 from current default 100.
…ting map at same time. (#282) Fixing error concurrent map iteration and map write error
shay-berman
suggested changes
Dec 25, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @tikolsky, @beckmani, and @shay-berman)
database/migrate.go, line 47 at r4 (raw file):
logger.ErrorRet(err, "failed") } delete(migrations, k)
lihi, this PR include many other changes that not related to this PR.
to avoid it, please delete you PR and branch feature/UB-211_move_build_script_to_git" (save you single file build_images.sh) and then create new branch from dev (make sure you did "git pull origin dev" before to get the latest changes) and then create new PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is