Refactor service interfaces to use request objects #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreadimaio
force-pushed
the
refactor-service-interfaces
branch
8 times, most recently
from
d886855 to
6e67aa0
Compare
- Removed default methods from ChatProvider interface and moved their implementations into ChatService - Replaced multiple parameter-based methods with unified request objects (TextGenerationRequest, TimeSeriesRequest) in provider interfaces - Rename FindByIdParameters in FindByIdRequest class - Updated DeploymentService to use request-based parameters - Streamlined method signatures across services to consistently use request objects Signed-off-by: andreadimaio <dmaio.andrea@gmail.com>
Signed-off-by: andreadimaio <dmaio.andrea@gmail.com>
Signed-off-by: andreadimaio <dmaio.andrea@gmail.com>
andreadimaio
force-pushed
the
refactor-service-interfaces
branch
from
6e67aa0 to
bb20273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatProviderinterface and moved their implementations intoChatServiceTextGenerationRequest,TimeSeriesRequest) in provider interfacesFindByIdParametersinFindByIdRequestclassDeploymentServiceto use request-based parameters