Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newline does not exist in older MATLAB releases #493

Closed
CsatiZoltan opened this issue Dec 13, 2018 · 2 comments · Fixed by #501
Closed

newline does not exist in older MATLAB releases #493

CsatiZoltan opened this issue Dec 13, 2018 · 2 comments · Fixed by #501
Assignees
@dweindl

Comments

@CsatiZoltan
Copy link

amimodel.compileAndLinkModel>getCompilerVersionString fails because it contains the newline function which was introduced in R2016b. Replacing it by char(10), as recommended in the link above, fixes the problem.
@FFroehlich
Copy link
Member

Hi, thank you for the remark. We generally recommend using more recent MATLAB versions as keeping backwards compatibility in MATLAB is just impossible as long as third party platforms such as travis.org do not allow automated testing. Unfortunately, we currently only support MATLAB up to R2017b.

@dweindl
Copy link
Member

dweindl commented Dec 14, 2018

Is guess I can quickly fix that. Only one single occurrence and fix won't affect upward or download compatibility.

@dweindl dweindl self-assigned this Dec 14, 2018
dweindl added a commit that referenced this issue Dec 14, 2018
@dweindl
fix(matlab) Replace by literal to restore <R2016b compatibility (Fixes …
59ca8c4 
…#493)
@dweindl dweindl mentioned this issue Dec 14, 2018
Merged
dweindl added a commit that referenced this issue Dec 14, 2018
@dweindl
fix(matlab) Replace 'newline' by literal to restore <R2016b compatibi…
0179c60 
…lity (Fixes #493)
dweindl added a commit that referenced this issue Dec 14, 2018
@dweindl
fix(matlab) Replace 'newline' by literal to restore <R2016b compatibi…
5789193 
…lity (Fixes #493)
dweindl added a commit that referenced this issue Dec 14, 2018
@dweindl
fix(matlab) Replace 'newline' by literal to restore <R2016b compatibi…
00dde90 
…lity (Fixes #493)
dweindl added a commit that referenced this issue Jan 7, 2019
@dweindl
fix(matlab) Replace 'newline' by literal to restore <R2016b compatibi…
b83c58b 
…lity (Fixes #493)
@dweindl dweindl mentioned this issue Jan 7, 2019
Merged
dweindl added a commit that referenced this issue Jan 7, 2019
@dweindl
Merge pull request #501 from ICB-DCM/release_v0.8.2
dce9bbc 
Release v0.8.2

Features / improvements:
* Speedup symbolic processing for ODE generation in python

Bugfixes:
* Fix(python) Add missing deepcopy (introduced in 6847ba6)
* Fix(core) Prevent parameter scaling length mismatch (#488)
* Fix(python) Set distutils dependency to current version to fix </usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'>
* fix(python) add symlink to version.txt to be included in package

Backwards-compatibility:
* Replace 'newline' by literal to restore <R2016b compatibility (Fixes #493)

Maintenance:
* Remove obsolete swig library build via cmake and related file copying
* Provide issue template for bug reports
* Providing valid SBML document to import is not optional anymore
* Update documentation and tests
* Add python version check and raise required version to 3.6 to prevent cryptic error messages when encountering f-strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v0.8.2 AMICI-dev/AMICI
3 participants
@CsatiZoltan @FFroehlich @dweindl