Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requirements petabtests closes #511 #512

Merged
merged 4 commits into from
Nov 23, 2020
Merged

Conversation

jvanhoefer
Copy link
Member

No description provided.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petabtests ist afaik not available as a pypi package, because it requires a custom install (would be possible, but didn't bother at the time), therefore it is custom-installed on CI from github.

@jvanhoefer
Copy link
Member Author

This made some problems with local testing for Simon and me today... are there any reasons, why this should not be on pypi? Otherwise, we can just do the link to the current GitHub Repo. Just I think, we should have this requirement in there.

@dweindl
Copy link
Member

dweindl commented Nov 20, 2020

are there any reasons, why this should not be on pypi?

No. Just needs to be packaged.

@jvanhoefer
Copy link
Member Author

jvanhoefer commented Nov 20, 2020

No. Just needs to be packaged.

Then I/we should wait with this PR until petabtests is on pypi :)

@yannikschaelte
Copy link
Member

No. Just needs to be packaged.

Then I/we should wait with this PR until petabtests is on pypi :)

@jvanhoefer done

@codecov-io
Copy link

Codecov Report

Merging #512 (91b0b8a) into develop (2f298a8) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #512      +/-   ##
===========================================
+ Coverage    89.93%   90.00%   +0.07%     
===========================================
  Files           72       72              
  Lines         4283     4283              
===========================================
+ Hits          3852     3855       +3     
+ Misses         431      428       -3     
Impacted Files Coverage Δ
pypesto/optimize/optimizer.py 87.05% <0.00%> (-0.28%) ⬇️
pypesto/sample/geweke_test.py 94.36% <0.00%> (+2.81%) ⬆️
pypesto/engine/multi_process.py 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f298a8...91b0b8a. Read the comment docs.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petabtests>=0.0.0a5 now also comes versioned 🎉

@jvanhoefer jvanhoefer merged commit f36d9b1 into develop Nov 23, 2020
@jvanhoefer jvanhoefer deleted the feature_fix_requirements branch November 23, 2020 10:26
@yannikschaelte yannikschaelte mentioned this pull request Jan 19, 2021
m-philipps pushed a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants