Minor tidy up

Removed not needed comment and replaced code segment with method call.
ICRAR · Jan 18, 2019 · a8af7e7 · a8af7e7
1 parent 8707176
commit a8af7e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/dlg/apps/bash_shell_app.py b/dlg/apps/bash_shell_app.py
@@ -229,7 +229,6 @@ def cancel(self):
         BarrierAppDROP.cancel(self)
         try:
             os.killpg(os.getpgid(self.proc.pid), signal.SIGTERM)
-            #self.proc.terminate()
         except:
             logger.exception("Error while terminating process %r", self.proc)
 

diff --git a/dlg/drop.py b/dlg/drop.py
@@ -876,14 +876,12 @@ def setError(self):
         '''
         Moves this DROP to the ERROR state.
         '''
-        # Close our writing IO instance.
-        # If written externally, self._wio will have remained None
-        if self._wio:
-            self._wio.close()
 
         if self.status == DROPStates.CANCELLED:
             return
 
+        self._closeWriters()
+
         logger.info("Moving %r to ERROR", self)
         self.status = DROPStates.ERROR