From efa8b0aeeea7e4693bd9ecd67bb35bde437341d7 Mon Sep 17 00:00:00 2001 From: Rodrigo Tobar Date: Tue, 3 Oct 2023 11:55:53 +0800 Subject: [PATCH] Bump dependency on Boost to >= 1.68 We used to depend on >= 1.54, but in a8096298 we accidentally raised the minimum required Boost version to 1.68 (boost::optional::has_value() was introduced in that version to align with std::optional). This version of Boost is 5 years old though, so instead of modifying our code to cope with older versions, we're probably better off declaring a higher minimum version. This was the original cause of #13, and thus it should prevent this issue from happening again in the near future. Signed-off-by: Rodrigo Tobar --- CMakeLists.txt | 2 +- doc/building.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ea45c3ce..86c1d111 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -175,7 +175,7 @@ macro(find_boost) # with homebrew). Let's thus not use Boost's cmake config file and stick to # cmake's own version of it for the time being set(Boost_NO_BOOST_CMAKE ON) - find_package(Boost 1.54 COMPONENTS filesystem log program_options system REQUIRED) + find_package(Boost 1.68 COMPONENTS filesystem log program_options system REQUIRED) set(SHARK_LIBS ${SHARK_LIBS} ${Boost_LIBRARIES}) include_directories(${Boost_INCLUDE_DIRS}) endmacro() diff --git a/doc/building.rst b/doc/building.rst index f9ce7aa6..6d56d7b2 100644 --- a/doc/building.rst +++ b/doc/building.rst @@ -19,7 +19,7 @@ Requirements * `GSL `_ >= 2.0 * `HDF5 `_ >= 1.8.0 -* `Boost `_ >= 1.54 +* `Boost `_ >= 1.68 Optional requirements are: