From 1aa78c99a246fa38e9e06e241379069b0b245dda Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Tue, 9 Sep 2025 14:58:14 -0700 Subject: [PATCH 1/9] update to v4 --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 0151406d..04e66e89 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -112,7 +112,7 @@ jobs: pytest -v idaes_examples --ignore=idaes_examples/notebooks/docs/surrogates/sco2/alamo/ - name: Upload pytest-xdist worker logs if: success() || failure() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: pytest_worker_logs path: "tests_*.log" From 47ccb93ee263f8be6e913c92dcc229442f0c4b66 Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Tue, 9 Sep 2025 15:38:01 -0700 Subject: [PATCH 2/9] make names for each run be unique --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 04e66e89..029c1ed1 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -114,5 +114,5 @@ jobs: if: success() || failure() uses: actions/upload-artifact@v4 with: - name: pytest_worker_logs + name: pytest_worker_logs-${{ github.job }}-${{github.run_attempt}} path: "tests_*.log" From 11c7104e14f4af45bf64e62925ea60392c046c0a Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Tue, 9 Sep 2025 16:44:25 -0700 Subject: [PATCH 3/9] make names for each run be unique with py version being tested --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 029c1ed1..5045a9a7 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -114,5 +114,5 @@ jobs: if: success() || failure() uses: actions/upload-artifact@v4 with: - name: pytest_worker_logs-${{ github.job }}-${{github.run_attempt}} + name: pytest_worker_logs-${{ github.job }}-${{github.run_attempt}}-py${{ matrix.python-version }} path: "tests_*.log" From fb69ef961fdb3aded7f03ccfa821e00eb8162f94 Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Fri, 12 Sep 2025 14:04:12 -0700 Subject: [PATCH 4/9] change naming mechanism to be more unique --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 5045a9a7..0eb8c497 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -114,5 +114,5 @@ jobs: if: success() || failure() uses: actions/upload-artifact@v4 with: - name: pytest_worker_logs-${{ github.job }}-${{github.run_attempt}}-py${{ matrix.python-version }} + name: pytest_worker_logs-${{ github.run_id }}-${{ github.run_attempt }} path: "tests_*.log" From 77a1975f09036ce49c6562fca1ccfc895fa65b0e Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Fri, 12 Sep 2025 14:17:35 -0700 Subject: [PATCH 5/9] experimenting with overwrite --- .github/workflows/core.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 0eb8c497..e2c4dc12 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -114,5 +114,6 @@ jobs: if: success() || failure() uses: actions/upload-artifact@v4 with: - name: pytest_worker_logs-${{ github.run_id }}-${{ github.run_attempt }} + name: pytest_worker_logs--${{ runner.os }}-${{ github.run_id }}-${{ github.run_attempt }} path: "tests_*.log" + overwrite: true From de8df5a1e946097f97e4d16d68cca54bb18b9c89 Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Fri, 12 Sep 2025 15:02:36 -0700 Subject: [PATCH 6/9] mimic changes that worked one year ago by tanner --- .github/workflows/core.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index e2c4dc12..eb26a12a 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -88,7 +88,7 @@ jobs: - win64 include: - os: linux - runner-image: ubuntu-20.04 + runner-image: ubuntu-latest - os: win64 runner-image: windows-2022 steps: @@ -116,4 +116,3 @@ jobs: with: name: pytest_worker_logs--${{ runner.os }}-${{ github.run_id }}-${{ github.run_attempt }} path: "tests_*.log" - overwrite: true From 4473073e9399979163b5f0b408bd7b654739d0d3 Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Fri, 12 Sep 2025 15:08:44 -0700 Subject: [PATCH 7/9] switch back to 22.04 --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index eb26a12a..a85a961c 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -88,7 +88,7 @@ jobs: - win64 include: - os: linux - runner-image: ubuntu-latest + runner-image: ubuntu-20.04 - os: win64 runner-image: windows-2022 steps: From b1e295d9f58ac4572c4fc3b5198d69a48d385275 Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Fri, 12 Sep 2025 15:14:34 -0700 Subject: [PATCH 8/9] trying if this version will have the tests work --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index a85a961c..90f45cc1 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -88,7 +88,7 @@ jobs: - win64 include: - os: linux - runner-image: ubuntu-20.04 + runner-image: ubuntu-22.04 - os: win64 runner-image: windows-2022 steps: From 8e286f137f301c3c05229f16a90631ea3a5e802c Mon Sep 17 00:00:00 2001 From: Sufi Kaur Date: Fri, 12 Sep 2025 15:36:42 -0700 Subject: [PATCH 9/9] make name unique --- .github/workflows/core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 90f45cc1..3ac8d2a4 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -114,5 +114,5 @@ jobs: if: success() || failure() uses: actions/upload-artifact@v4 with: - name: pytest_worker_logs--${{ runner.os }}-${{ github.run_id }}-${{ github.run_attempt }} + name: pytest_worker_logs--${{ runner.os }}-${{ github.run_id }}-${{ github.run_attempt }}-${{ runner.os }}-py${{ matrix.python-version }} path: "tests_*.log"