Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PySMO's confidence interval function to new surrogate interface #1005

Merged
merged 15 commits into from Nov 14, 2022

Conversation

OOAmusat
Copy link
Contributor

@OOAmusat OOAmusat commented Nov 2, 2022

Summary/Motivation:

This PR adds a wrapper for PySMO's confint_regression method, allowing users to calculate confidence intervals for polynomial regression models using the new surrogate interface.

Changes proposed in this PR:

  • Wrapper for PySMO's confint_regression method
  • Tests for the wrapper
  • Documentation for the wrapper

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@OOAmusat OOAmusat marked this pull request as draft November 2, 2022 00:32
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 70.13% // Head: 70.16% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (58c0baa) compared to base (e83e159).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   70.13%   70.16%   +0.02%     
==========================================
  Files         398      398              
  Lines       64951    64956       +5     
  Branches    12020    12021       +1     
==========================================
+ Hits        45555    45576      +21     
+ Misses      17070    17054      -16     
  Partials     2326     2326              
Impacted Files Coverage Δ
idaes/core/surrogate/pysmo_surrogate.py 91.77% <100.00%> (+0.13%) ⬆️
idaes/ver.py 61.53% <0.00%> (-4.62%) ⬇️
...daes/core/surrogate/pysmo/polynomial_regression.py 86.09% <0.00%> (+3.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OOAmusat OOAmusat marked this pull request as ready for review November 2, 2022 17:19
@OOAmusat OOAmusat requested review from bpaul4, dangunter and lbianchi-lbl and removed request for lbianchi-lbl November 2, 2022 17:19
@OOAmusat OOAmusat changed the title Add PySMO's confidence interval function to new surrogate SI Add PySMO's confidence interval function to new surrogate interface Nov 2, 2022
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple comments about the changes here.

It would also be good for us to add support for plotting PySMO (and ALAMO) confidence intervals on 2D scatter and parity plots in a future PR for the visualization tools.

@OOAmusat OOAmusat requested a review from bpaul4 November 2, 2022 22:14
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this, @OOAmusat.

Copy link
Member

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on documentation and code style

@OOAmusat OOAmusat self-assigned this Nov 3, 2022
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 3, 2022
Copy link
Member

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More doc comments

idaes/core/surrogate/pysmo_surrogate.py Outdated Show resolved Hide resolved
idaes/core/surrogate/pysmo_surrogate.py Show resolved Hide resolved
Copy link
Member

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewlee94 andrewlee94 enabled auto-merge (squash) November 14, 2022 15:22
@andrewlee94 andrewlee94 merged commit 901a976 into IDAES:main Nov 14, 2022
@OOAmusat OOAmusat deleted the PySMO-SI-confint branch November 14, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants