New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PySMO's confidence interval function to new surrogate interface #1005
Conversation
Codecov ReportBase: 70.13% // Head: 70.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 70.13% 70.16% +0.02%
==========================================
Files 398 398
Lines 64951 64956 +5
Branches 12020 12021 +1
==========================================
+ Hits 45555 45576 +21
+ Misses 17070 17054 -16
Partials 2326 2326
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple comments about the changes here.
It would also be good for us to add support for plotting PySMO (and ALAMO) confidence intervals on 2D scatter and parity plots in a future PR for the visualization tools.
docs/explanations/modeling_extensions/surrogate/api/pysmo/pysmo_polyregression.rst
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding this, @OOAmusat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments on documentation and code style
docs/explanations/modeling_extensions/surrogate/api/pysmo/pysmo_polyregression.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More doc comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary/Motivation:
This PR adds a wrapper for PySMO's
confint_regression
method, allowing users to calculate confidence intervals for polynomial regression models using the new surrogate interface.Changes proposed in this PR:
confint_regression
methodLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: