[API change] Getting rid of the create method for observers v0.99999 #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2019
JarnoRFB
reviewed
Aug 21, 2019
Co-Authored-By: Rüdiger Busche <ruedigerbusche@web.de>
boeddeker
reviewed
Aug 21, 2019
sacred/observers/sql.py
Outdated
| @classmethod | ||
| def create_from(cls, engine, session, priority=DEFAULT_SQL_PRIORITY): | ||
| """Second constructor, Java style""" | ||
| self = cls.__new__(cls) |
There was a problem hiding this comment.
Maybe adding a comment: e.g.: self = cls.__new__(cls) # skip __init__ call
|
Sorry for taking the fun out of the docstring :D I feel we finally converged on something here! Thanks for hanging on this issue. |
My pleasure. Sacred is an amazing tool. My feeling was that the API wasn't that pretty, this is a good step toward making it very easy to understand and use. I guess a intuitive API is what was missing for a broader adoption. |
|
Let's get a final review from @Qwlouse , afterwards, we can merge and I'll start working on the API change for the other observers. |
Qwlouse
approved these changes
Aug 21, 2019
JarnoRFB
approved these changes
Aug 21, 2019
|
Thanks a lot @boeddeker for your idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.