From 1a8f6f4eb6f0662607b46712c8dfc8e90d7cf7e6 Mon Sep 17 00:00:00 2001
From: danranvm <danranvm@gmail.com>
Date: Thu, 16 Jun 2022 15:39:48 +0800
Subject: [PATCH] fix(comp:table): set expandable trigger button type

---
 .../__snapshots__/carousel.spec.ts.snap       |  4 ++--
 packages/components/carousel/src/Carousel.tsx |  2 +-
 .../__snapshots__/table.spec.ts.snap          | 20 +++++++++----------
 .../table/src/main/body/BodyCell.tsx          |  2 +-
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/packages/components/carousel/__tests__/__snapshots__/carousel.spec.ts.snap b/packages/components/carousel/__tests__/__snapshots__/carousel.spec.ts.snap
index 9b28d9f9c..08de06933 100644
--- a/packages/components/carousel/__tests__/__snapshots__/carousel.spec.ts.snap
+++ b/packages/components/carousel/__tests__/__snapshots__/carousel.spec.ts.snap
@@ -18,8 +18,8 @@ exports[`Carousel > render work 1`] = `
   </div>
   <!---->
   <ul class=\\"ix-carousel-dot ix-carousel-dot-bottom\\">
-    <li class=\\"ix-carousel-dot-item ix-carousel-dot-item-active\\"><button class=\\"ix-carousel-dot-item-default\\"></button></li>
-    <li class=\\"ix-carousel-dot-item\\"><button class=\\"ix-carousel-dot-item-default\\"></button></li>
+    <li class=\\"ix-carousel-dot-item ix-carousel-dot-item-active\\"><button class=\\"ix-carousel-dot-item-default\\" type=\\"button\\"></button></li>
+    <li class=\\"ix-carousel-dot-item\\"><button class=\\"ix-carousel-dot-item-default\\" type=\\"button\\"></button></li>
   </ul>
 </div>"
 `;
diff --git a/packages/components/carousel/src/Carousel.tsx b/packages/components/carousel/src/Carousel.tsx
index b154bb063..7b877942b 100644
--- a/packages/components/carousel/src/Carousel.tsx
+++ b/packages/components/carousel/src/Carousel.tsx
@@ -118,7 +118,7 @@ export default defineComponent({
         const children = slots.dot ? (
           slots.dot({ index, isActive })
         ) : (
-          <button class={`${prefixCls}-dot-item-default`}></button>
+          <button class={`${prefixCls}-dot-item-default`} type="button"></button>
         )
         return (
           <li key={node.key!} class={itemClass} onClick={() => onClick(index)} onMouseenter={() => onMouseenter(index)}>
diff --git a/packages/components/table/__tests__/__snapshots__/table.spec.ts.snap b/packages/components/table/__tests__/__snapshots__/table.spec.ts.snap
index f25623252..ed2946871 100644
--- a/packages/components/table/__tests__/__snapshots__/table.spec.ts.snap
+++ b/packages/components/table/__tests__/__snapshots__/table.spec.ts.snap
@@ -39,7 +39,7 @@ exports[`Table > basic work > render work 1`] = `
         <tbody>
           <!---->
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
             <td class=\\"ix-table-align-start\\">
               <!----><label class=\\"ix-checkbox ix-checkbox-disabled\\" role=\\"checkbox\\" aria-checked=\\"false\\" aria-disabled=\\"true\\"><span class=\\"ix-checkbox-input\\"><input type=\\"checkbox\\" class=\\"ix-checkbox-input-inner\\" aria-hidden=\\"true\\" disabled=\\"\\"><span class=\\"ix-checkbox-input-box\\"></span></span>
                 <!---->
@@ -65,7 +65,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\">
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\">
                 <!---->
               </button><a></a></td>
             <td class=\\"ix-table-align-start\\">
@@ -93,7 +93,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\">
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\">
                 <!---->
               </button><a></a></td>
             <td class=\\"ix-table-align-start\\">
@@ -121,7 +121,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
             <td class=\\"ix-table-align-start\\">
               <!----><label class=\\"ix-checkbox ix-checkbox-disabled\\" role=\\"checkbox\\" aria-checked=\\"false\\" aria-disabled=\\"true\\"><span class=\\"ix-checkbox-input\\"><input type=\\"checkbox\\" class=\\"ix-checkbox-input-inner\\" aria-hidden=\\"true\\" disabled=\\"\\"><span class=\\"ix-checkbox-input-box\\"></span></span>
                 <!---->
@@ -147,7 +147,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\">
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\">
                 <!---->
               </button><a></a></td>
             <td class=\\"ix-table-align-start\\">
@@ -175,7 +175,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\">
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\">
                 <!---->
               </button><a></a></td>
             <td class=\\"ix-table-align-start\\">
@@ -203,7 +203,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
             <td class=\\"ix-table-align-start\\">
               <!----><label class=\\"ix-checkbox ix-checkbox-disabled\\" role=\\"checkbox\\" aria-checked=\\"false\\" aria-disabled=\\"true\\"><span class=\\"ix-checkbox-input\\"><input type=\\"checkbox\\" class=\\"ix-checkbox-input-inner\\" aria-hidden=\\"true\\" disabled=\\"\\"><span class=\\"ix-checkbox-input-box\\"></span></span>
                 <!---->
@@ -229,7 +229,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\">
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\">
                 <!---->
               </button><a></a></td>
             <td class=\\"ix-table-align-start\\">
@@ -257,7 +257,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\">
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\">
                 <!---->
               </button><a></a></td>
             <td class=\\"ix-table-align-start\\">
@@ -285,7 +285,7 @@ exports[`Table > basic work > render work 1`] = `
             </td>
           </tr>
           <tr class=\\"\\">
-            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
+            <td class=\\"ix-table-align-start\\"><button class=\\"ix-table-expandable-trigger\\" type=\\"button\\"><i class=\\"ix-icon ix-icon-right\\" style=\\"transform: rotate(0deg);\\" role=\\"img\\" aria-label=\\"right\\"></i></button><a></a></td>
             <td class=\\"ix-table-align-start\\">
               <!----><label class=\\"ix-checkbox ix-checkbox-disabled\\" role=\\"checkbox\\" aria-checked=\\"false\\" aria-disabled=\\"true\\"><span class=\\"ix-checkbox-input\\"><input type=\\"checkbox\\" class=\\"ix-checkbox-input-inner\\" aria-hidden=\\"true\\" disabled=\\"\\"><span class=\\"ix-checkbox-input-box\\"></span></span>
                 <!---->
diff --git a/packages/components/table/src/main/body/BodyCell.tsx b/packages/components/table/src/main/body/BodyCell.tsx
index 1989e895d..6a86c2f1d 100644
--- a/packages/components/table/src/main/body/BodyCell.tsx
+++ b/packages/components/table/src/main/body/BodyCell.tsx
@@ -179,7 +179,7 @@ function renderExpandableChildren(
   }
 
   return (
-    <button class={`${prefixCls}-expandable-trigger`} style={style} onClick={props.handleExpend}>
+    <button class={`${prefixCls}-expandable-trigger`} style={style} type="button" onClick={props.handleExpend}>
       {iconNode}
     </button>
   )