Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All ordered lists should be `items` #1145

Closed
azaroth42 opened this Issue May 1, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@azaroth42
Copy link
Member

azaroth42 commented May 1, 2017

If we are moving to collection.members and range.members, should we also rename canvases on Sequence?

Further, as we are moving to the Activity Streams pattern for Annotation Lists per https://www.w3.org/TR/annotation-model/#annotation-page and #496 ... I think we should actually use items to be consistent throughout.

@azaroth42 azaroth42 added this to the Presentation 3.0 milestone May 1, 2017

@azaroth42

This comment has been minimized.

Copy link
Member Author

azaroth42 commented Jun 5, 2017

In other words:

{
  "type": "Collection",
  "items": [
    {
      "type": "Manifest",
      "items": [
        {
          "type": "Sequence",
          "items": [
            {
              "type": "Canvas",
              "items": [
                {
                  "type": "AnnotationPage",
                  "items": [
                    {
                      "type": "Annotation"
@azaroth42

This comment has been minimized.

Copy link
Member Author

azaroth42 commented Jun 27, 2017

Is it confusing, inconsistent, or worse that AnnotationPage objects can be in the items lists of both Canvas and AnnotationCollection (previously known as Layer)?

@tomcrane

This comment has been minimized.

Copy link
Contributor

tomcrane commented Jun 28, 2017

I was +1 to the idea of items everywhere, but now I'm wondering if the intent conveyed by terms like content, to associate a canvas with its content, is more important as an aid to understanding what is going on than the consistency of using the same term to associate resources with AnnotationPage (and other resources) throughout. I'm not -1 though.

@azaroth42 azaroth42 added the normative label Sep 15, 2017

@azaroth42 azaroth42 added the ratify label Sep 28, 2017

@azaroth42

This comment has been minimized.

Copy link
Member Author

azaroth42 commented Sep 28, 2017

c.f. #1068 -- is the set of annotationpages for a Canvas items and the set of AnnotationPages on everything else annotations?

@tomcrane

This comment has been minimized.

Copy link
Contributor

tomcrane commented Sep 28, 2017

I am now 👍 as it resolves a difficult naming problem elsewhere.

However, even though we're still in alpha, the term content is now familiar to many people from the Presentation 3 work.

So I will email iiif-discuss to explain the proposed naming, ahead of Toronto.

@zimeon

This comment has been minimized.

Copy link
Member

zimeon commented Oct 12, 2017

👍 agreed at Toronto WG meeting

@azaroth42

This comment has been minimized.

Copy link
Member Author

azaroth42 commented Nov 3, 2017

Done, and duplicate of the renaming issue: http://prezi3.iiif.io/api/presentation/3.0/#items

@azaroth42 azaroth42 added Ready-for-Eds and removed ratify labels Nov 3, 2017

@zimeon

This comment has been minimized.

Copy link
Member

zimeon commented Nov 7, 2017

👍 agree done (and nice intro text)

@mikeapp

This comment has been minimized.

Copy link
Member

mikeapp commented Nov 7, 2017

👍 also agree done, closing

@mikeapp mikeapp closed this Nov 7, 2017

@azaroth42 azaroth42 referenced this issue Dec 20, 2017

Closed

(several) to items #5

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.