Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot.js: prevent 'baselayerchange' to fire second time (on mobile) #291

Merged
merged 1 commit into from Dec 31, 2019

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Dec 11, 2019

Fix issue with minimap.

Background: mobile app uses native layer chooser instead of standard Control.Layers,
so window.layerChooser has additional code to support that.

Perhaps it was needed to fire 'baselayerchange' manually a long time ago,
but not in leaflet 1.

This is just quick fix for particular issue appeared with minimap on mobile
But in fact the whole layerChooser should be reimplemented from scratch.
Mobile-specific parts of code should be separated.

Fix issue with minimap.

Background: mobile app uses native layer chooser instead of standard Control.Layers,
so window.layerChooser has additional code to support that.

Perhaps it was needed to fire 'baselayerchange' manually a long time ago,
but not in leaflet 1.

!!This is just quick fix for particular issue appeared with minimap on mobile!!
But in fact the whole layerChooser should be reimplemented from scratch.
Mobile-specific parts of code should be separated.
@johnd0e johnd0e added bug core labels Dec 11, 2019
@johnd0e johnd0e added this to Priority in Track features for next release via automation Dec 11, 2019
@johnd0e johnd0e moved this from Priority to Testing in Track features for next release Dec 21, 2019
@johnd0e johnd0e requested a review from modos189 Dec 30, 2019
@johnd0e johnd0e merged commit 9061e06 into IITC-CE:master Dec 31, 2019
Track features for next release automation moved this from Testing to Merged Dec 31, 2019
@johnd0e johnd0e deleted the quickfix-layerchooser branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core
Development

Successfully merging this pull request may close these issues.

None yet

2 participants