Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot.js: fix handling of plugins setup 'highest' priority #307

Merged
merged 1 commit into from Jan 13, 2020

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Jan 11, 2020

By a coincedence numeric value was 0 which is considered as false in javascript

Note: avoid using of 'highest' value as it's not documented and is subject to change


This change is Reviewable

By a coincedence numeric value was 0 which is considered as false in javascript

Note: avoid using of 'highest' value as it's not documented and is subject to change
@johnd0e johnd0e requested a review from modos189 Jan 13, 2020
@johnd0e johnd0e marked this pull request as ready for review Jan 13, 2020
@johnd0e johnd0e merged commit b9e9c02 into IITC-CE:master Jan 13, 2020
@johnd0e johnd0e deleted the fix-highest-priority branch Jan 13, 2020
@johnd0e johnd0e added this to Priority in Track features for next release via automation Jan 13, 2020
@johnd0e johnd0e moved this from Priority to Merged in Track features for next release Jan 13, 2020
@johnd0e johnd0e added bug core labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core
Development

Successfully merging this pull request may close these issues.

None yet

2 participants