Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw-tools: fix touch on iOS #308

Merged
merged 2 commits into from Jan 17, 2020
Merged

draw-tools: fix touch on iOS #308

merged 2 commits into from Jan 17, 2020

Conversation

@johnd0e
Copy link
Contributor

johnd0e commented Jan 11, 2020

As it appeared, our attempt to fix Leaflet.draw bug in #175
is not good for some environments, e.g. it prevents proper touch
detecting on iOS (observed while drawing polygons)


This change is Reviewable

@modos189

This comment has been minimized.

Copy link
Contributor

modos189 commented Jan 11, 2020

Does this enable or disable touch mode? The safari browser is also desktop (OSX).

@johnd0e

This comment has been minimized.

Copy link
Contributor Author

johnd0e commented Jan 11, 2020

It just reduces our intervention into original Leaflet.draw code.
BTW, no matter desktop or mobile, as either can be equiped with touchscreen.

@johnd0e johnd0e added this to Priority in Track features for next release via automation Jan 13, 2020
johnd0e added 2 commits Jan 11, 2020
As it appeared, our attempt to fix Leaflet.draw [bug] in #175
is not good for some environments, e.g. it prevents proper touch
detection on iOS (observed while drawing polygons).

[bug]: Leaflet/Leaflet.draw#789
@johnd0e johnd0e force-pushed the johnd0e:fix-draw-tools-ios branch from 5c977ff to 2d8bd34 Jan 15, 2020
@johnd0e johnd0e marked this pull request as ready for review Jan 15, 2020
@johnd0e johnd0e requested a review from modos189 Jan 15, 2020
@johnd0e johnd0e merged commit 0e43f15 into IITC-CE:master Jan 17, 2020
Track features for next release automation moved this from Priority to Merged Jan 17, 2020
@johnd0e johnd0e deleted the johnd0e:fix-draw-tools-ios branch Jan 17, 2020
johnd0e added a commit to johnd0e/ingress-intel-total-conversion that referenced this pull request Jan 22, 2020
- revert part of 6ea92c6 (IITC-CE#175)
- fix IITC-CE#315
  actually issue of leaflet, previously was masked by overriden useragent, which was fixed by IITC-CE#289
- better fix for iOS
  fix from IITC-CE#308 was not perfect anyway, as it dropped markers even on map drag.
johnd0e added a commit to johnd0e/ingress-intel-total-conversion that referenced this pull request Jan 22, 2020
- revert part of 6ea92c6 (IITC-CE#175)
- fix IITC-CE#315
  actually issue of leaflet, previously was masked by overriden useragent, which was fixed by IITC-CE#289
- better fix for iOS
  fix from IITC-CE#308 was not perfect anyway, as it dropped markers even on map drag.
johnd0e added a commit to johnd0e/ingress-intel-total-conversion that referenced this pull request Jan 22, 2020
- revert part of 6ea92c6 (IITC-CE#175)
- fix IITC-CE#315
  actually issue of leaflet, previously was masked by overriden useragent, which was fixed by IITC-CE#289
- better fix for iOS
  fix from IITC-CE#308 was not perfect anyway, as it dropped markers even on map drag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.