Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-fix for old android versions with pre-ES2015 webview #309

Merged
merged 1 commit into from Jan 15, 2020

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Jan 14, 2020

Issue observed under x86 android kitkat/lollypop emulator:
as appeared, ulog module fails trying to redefine function name property.
Download/ulog#24

So now we detect this case and then replace ulog with a stub.


This change is Reviewable

@johnd0e johnd0e added the bug label Jan 14, 2020
@johnd0e johnd0e added this to Priority in Track features for next release via automation Jan 14, 2020
@modos189
Copy link
Contributor

@modos189 modos189 commented Jan 14, 2020

It works

Issue observed under x86 android kitkat/lollypop emulator:
as appeared, ulog module fails trying to redefine function name property.
Download/ulog#24

So now we detect this case and then replace ulog with a stub.
@johnd0e johnd0e marked this pull request as ready for review Jan 15, 2020
@johnd0e johnd0e merged commit 5b2ea17 into IITC-CE:master Jan 15, 2020
Track features for next release automation moved this from Priority to Merged Jan 15, 2020
@johnd0e johnd0e deleted the fix-ulog branch Jan 15, 2020
johnd0e added a commit to johnd0e/ingress-intel-total-conversion that referenced this issue Jun 27, 2020
modos189 pushed a commit that referenced this issue Jul 3, 2020
See Download/ulog#24

This reverts commit 5b2ea17, reversing
changes made to b9e9c02.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Development

Successfully merging this pull request may close these issues.

None yet

2 participants