Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issues of L.CanvasIconLayer #313

Merged
merged 4 commits into from Jan 18, 2020
Merged

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Jan 17, 2020

As it appeared, not all browsers canvas implementations are equal.
Performance issues reported for FF, Safari, and not up-to-date Android WebView.

Here we are trying to fix some issues by reducing padding, and setting display: 'none'; style for empty canvases.


This change is Reviewable

johnd0e added 4 commits Jan 17, 2020
`1` was too much for browsers with bad implementation of canvas.
`0.5` can be enough, as we really pan at more than half a screen.
New flag: window.DISABLE_CANVASICONLAYER
IITC-CE/Leaflet.Canvas-Markers#14
Solves performance issue caused by several large overlapping canvases,
observed in some browsers (especially while zooming/panning).

As it appeared, not all browsers canvas implementations are equal.
Issues reported for FF, Safari, and not up-to-date Android WebView.

TODO: reimplement the fix in better way
@johnd0e johnd0e added the bug label Jan 17, 2020
@johnd0e johnd0e added this to Priority in Track features for next release via automation Jan 17, 2020
@modos189 modos189 merged commit 2fd04ee into IITC-CE:master Jan 18, 2020
Track features for next release automation moved this from Priority to Merged Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Development

Successfully merging this pull request may close these issues.

None yet

2 participants