Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android KitKat support #470

Merged
merged 1 commit into from Apr 6, 2021
Merged

Fix Android KitKat support #470

merged 1 commit into from Apr 6, 2021

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Mar 20, 2021 •
edited

  • Get rid of Math.trunc in makePermalink function
  • Add polyfill (just in case)

This change is Reviewable

Fix Android KitKat support
654af8a 
- Get rid of Math.trunc in makePermalink function
- Add polyfill (just in case)
@johnd0e johnd0e added bug Something isn't working core labels Mar 20, 2021
@johnd0e johnd0e added this to Priority in Track features for next release via automation Mar 20, 2021
@johnd0e johnd0e moved this from Priority to Testing in Track features for next release Mar 20, 2021
@johnd0e johnd0e requested a review from modos189 March 20, 2021 11:18
@johnd0e johnd0e moved this from Testing to Done in Track features for next release Mar 23, 2021
@johnd0e johnd0e requested a review from modos189 March 23, 2021 14:26
modos189
modos189 approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@modos189 modos189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@johnd0e johnd0e merged commit d548a89 into IITC-CE:master Apr 6, 2021
Track features for next release automation moved this from Done to Merged Apr 6, 2021
@johnd0e johnd0e deleted the math-trunk-polyfill branch April 6, 2021 13:08
@johnd0e johnd0e mentioned this pull request Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modos189 modos189 modos189 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core
Projects
Track features for next release
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnd0e @modos189