New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird characters in filenames breaks loading gpg files #10

Closed
eirc opened this Issue Sep 22, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@eirc

eirc commented Sep 22, 2014

I had parentheses in a filename and they broke the decryption command. I think that will happen with other characters that have a function in the shell. The app run ok but just outputted the errors in the decryption area:

sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `/usr/local/bin/pass filename-with-(parentheses)'

I guess just quoting the files where you run the external commands would do the job but I'm no CPP expert... I think it's here: https://github.com/IJHack/qtpass/blob/master/mainwindow.cpp#L189

@rdoeffinger

This comment has been minimized.

Contributor

rdoeffinger commented Apr 6, 2015

I think 6addb97 fixed this for most cases. As it uses simple "" quoting that still leaves files with " or $ in them broken though.

@annejan

This comment has been minimized.

Member

annejan commented May 4, 2015

More safeguarding added, and yes some characters still break.

Might have to just disable those on an interface level (the quotes and dollar and other things that break bash).

@annejan

This comment has been minimized.

Member

annejan commented Jul 19, 2015

Have tried to break, there is just the magic subfolder creating / which I'm keeping in for now . .

@annejan annejan closed this Jul 19, 2015

annejan pushed a commit that referenced this issue Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment