Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: moving items (reordering folders) #116

Closed
dromer opened this issue Nov 18, 2015 · 16 comments
Closed

Feature: moving items (reordering folders) #116

dromer opened this issue Nov 18, 2015 · 16 comments
Assignees

Comments

@dromer
Copy link

@dromer dromer commented Nov 18, 2015

It would be nice if the folder-structures could be re-ordered or moved around.

@annejan
Copy link
Member

@annejan annejan commented Nov 18, 2015

I'm wondering what kind of re-ordering you mean.
Do you mean moving items within the the folder structure?

├── internal
│   ├── first
│   └── second
└── external

Moving the 'first' item from internal to external (causing a (git) move) of the file.

Or just visibly (re)ordering the items (moving second above first or external above internal)?
Without causing any changes in the actual password-store.

@dromer
Copy link
Author

@dromer dromer commented Nov 18, 2015

Indeed I mean your first example.

I guess this also has implications for which gpg-keys have access.

@annejan
Copy link
Member

@annejan annejan commented Nov 18, 2015

Yes indeed, the files might need to be re-encrypted for this to work well 👍
Renamed issue for clarity . .

@annejan annejan changed the title Feature: reordering folders Feature: moving items (reordering folders) Nov 23, 2015
@nbm077
Copy link

@nbm077 nbm077 commented May 30, 2016

hey just watching this feature

@jounathaen
Copy link
Member

@jounathaen jounathaen commented Nov 17, 2016

Would also be a nice idea, to rename password files

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 20, 2016

This would mean a pass folder1/file1 to get the content, a pass insert folder2/file2 (with the read content) and a pass rm folder1/file1, right?
Same for renaming.

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 21, 2016

just saw: we simply need a pass mv oldpath newpath. That should be an easy feature.

@annejan
Copy link
Member

@annejan annejan commented Nov 21, 2016

@YoshiMan and a normal mv or git mv for the non-pass users.

Interface wise I think the treeview should be able to support moving . .
And for renaming possibly an added right-click feature . .

@jounathaen
Copy link
Member

@jounathaen jounathaen commented Nov 21, 2016

Note: The default Key for renaming is F2

Am 21. November 2016 10:40:14 vorm. schrieb Anne Jan Brouwer
notifications@github.com:

@YoshiMan and a normal mv or git mv for the non-pass users.

Interface wise I think the treeview should be able to support moving . .
And for renaming possibly an added right-click feature . .

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#116 (comment)

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 21, 2016

@annejan yeah you are right.

  1. so moving will work with drag and drop on the treeview, right?
    This will result into
    1.1 a pass mv when usepass is active or
    1.2 a git mv when usegit is active, followed by a git commit -m moved file from X to Y or
    1.3 a simple mv otherwise.

Renaming would work the same way, but with rightclick->rename or with the f2-key a dialog pops up, where you can type a new name.

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 23, 2016

I would implemnt this feature.
How do I assign it to me?
I implemented a basic drag and drop as POC. So I will invest some further work or should i work on something more important?

@annejan
Copy link
Member

@annejan annejan commented Nov 23, 2016

Please, work on whatever you fancy :) fun is more important than productivity in my opinion . .

It seems only IJhack members can be assigned to :/
Well .. let's go make some people members then . . .

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 24, 2016

Yeah fun is the most important thing while working on whatever ;)
Thank you. But I still cant assig it to myself -.-

@annejan
Copy link
Member

@annejan annejan commented Nov 24, 2016

@YoshiMan you should now (added repo to team) be able to assign . .
New issue for implementation #239

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Nov 25, 2016

@annejan still not able to assign. We can close this issue. Since we have a new one

@annejan
Copy link
Member

@annejan annejan commented Nov 25, 2016

I'll have a look into rights management . . perhaps only admins can assign?

@annejan annejan closed this Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.