Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon theme and Cinnamon #146

Closed
jounathaen opened this issue Jan 23, 2016 · 9 comments
Closed

Icon theme and Cinnamon #146

jounathaen opened this issue Jan 23, 2016 · 9 comments

Comments

@jounathaen
Copy link
Member

@jounathaen jounathaen commented Jan 23, 2016

The Icons on the Buttons don't show up under Cinnamon.
Installed on a fresh Virtual Machine running Linux Mint 17.3 - Cinnamon:
screenshot from 2016-01-22 23 26 23

This is how it should look like:
screenshot from 2016-01-22 23 30 07

On a fresh Virtual Machine running Linux Mint 17.3 - KDE, it works fine.
screenshot from 2016-01-23 11 34 52

@jounathaen
Copy link
Member Author

@jounathaen jounathaen commented Jan 23, 2016

Ok,the SVG Module was not Installed. But with the module installed, I "only" get the non-system-theme Icons.

@annejan
Copy link
Member

@annejan annejan commented Jan 25, 2016

Looking at Cinnamon issue . .
Can reproduce this on a clean mint install . . looking to fix (and addding SVG as dependency to README etc) . .

It seems this is an issue with the default theme support in Cinnamon (gtk2)
https://wiki.archlinux.org/index.php/Uniform_look_for_Qt_and_GTK_applications#QGtkStyle

By default it seems there are 3 icon sets installed, High-Contrast, Mint-X and gnome.
Of these the Mint-X seems to be the one that should be used.
For some reason it seems Qt doesn't "get" that it should be used (hence uses fallback).

Looking into environment variables and what-not to fix this . .
It does seem that "Show icons on buttons" setting is normally off on Cinnamon, but we are not using that hint in QtPass (except for in the profiles configuration tab) . .

@annejan annejan mentioned this issue Jan 25, 2016
@annejan
Copy link
Member

@annejan annejan commented Jan 25, 2016

I've found the trick @jounathaen :D

export DESKTOP_SESSION=gnome

Added to FAQ

Before:
screen shot 2016-01-25 at 10 51 58
After:
screen shot 2016-01-25 at 10 49 07

@annejan annejan closed this Jan 25, 2016
@annejan
Copy link
Member

@annejan annejan commented Jan 25, 2016

Mmmm wait .. this is the wrong theme still . . looking further . .

@annejan annejan reopened this Jan 25, 2016
@jounathaen
Copy link
Member Author

@jounathaen jounathaen commented Jan 25, 2016

That is a nice workaround, but in my first pull request, I somehow managed
to do this in another way. (Using the Cinnamon Icons, Not the Gnome ones).
Unfortunately I can't remember how I've done that. When I find out again,
I'll Post it of course. Best Regards!

@annejan
Copy link
Member

@annejan annejan commented Jan 25, 2016

Checked out your commit jounathaen@f7e9151 (on clean Cinnamon Mint)
Unfortunately (or possibly fortunately) it doesn't show any icons . .
Neither does your master . .

So it must be an environment trick . .

export DESKTOP_SESSION=gnome
export GTK2_RC_FILES=/usr/share/themes/Mint-X/gtk-2.0

Gives me yet another icon theme . . which is kinda sleek but still not what we want . .

....

@jounathaen
Copy link
Member Author

@jounathaen jounathaen commented Jan 25, 2016

Ohh good. These f#@?¥ Dependencies. Would a precompiled binary help, or is
the icon set choosen at compile time?

@annejan
Copy link
Member

@annejan annejan commented Jan 25, 2016

The fallback icons (svgs) are compiled in, the freedesktop theme is loaded at runtime @jounathaen
So that's even "worse" or "better" than compile time 😁

Between my tests I have not recompiled, just set different env flags and (re)started qtpass

@jounathaen
Copy link
Member Author

@jounathaen jounathaen commented Jan 28, 2016

Ok, I got a solution.
The default Qt Version on Linux mint is 5.2 or something like that. When installing Qt 5.5 manually from qt.io, then it works!
screenshot from 2016-01-28 11 31 00

@jounathaen jounathaen closed this Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.