Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: not working due to pointless use of "sh" #16

Closed
rdoeffinger opened this issue Mar 29, 2015 · 1 comment
Closed

Windows: not working due to pointless use of "sh" #16

rdoeffinger opened this issue Mar 29, 2015 · 1 comment

Comments

@rdoeffinger
Copy link
Contributor

@rdoeffinger rdoeffinger commented Mar 29, 2015

Simply letting Qt handle the argument splitting makes it work on Windows.
Plus, the code is more obvious.
diff --git a/mainwindow.cpp b/mainwindow.cpp
index 616fb92..0553b5e 100644
--- a/mainwindow.cpp
+++ b/mainwindow.cpp
@@ -188,7 +188,7 @@ void MainWindow::executePass(QString args) {
*/
void MainWindow::executeWrapper(QString app, QString args) {
process->setWorkingDirectory(passStore);

  • process->start("sh", QStringList() << "-c" << app + " " + args);
  • process->start(app + " " + args);
    ui->textBrowser->clear();
    ui->textBrowser->setTextColor(Qt::black);
    enableUiElements(false);
@rdoeffinger rdoeffinger closed this Apr 6, 2015
@rdoeffinger
Copy link
Contributor Author

@rdoeffinger rdoeffinger commented Apr 6, 2015

Fixed by my patches being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant