Skip to content

Windows: not working due to pointless use of "sh" #16

@rdoeffinger

Description

@rdoeffinger

Simply letting Qt handle the argument splitting makes it work on Windows.
Plus, the code is more obvious.
diff --git a/mainwindow.cpp b/mainwindow.cpp
index 616fb92..0553b5e 100644
--- a/mainwindow.cpp
+++ b/mainwindow.cpp
@@ -188,7 +188,7 @@ void MainWindow::executePass(QString args) {
*/
void MainWindow::executeWrapper(QString app, QString args) {
process->setWorkingDirectory(passStore);

  • process->start("sh", QStringList() << "-c" << app + " " + args);
  • process->start(app + " " + args);
    ui->textBrowser->clear();
    ui->textBrowser->setTextColor(Qt::black);
    enableUiElements(false);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions