New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short fullname hangs QtPass keypair generation process for infinite time #202

Closed
dakk opened this Issue Sep 30, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@dakk
Contributor

dakk commented Sep 30, 2016

I was trying to initialize QPass by creating a keypair. I put my fullname and other requested info. Then the "Generating a gnupg keypair" window appears, but after 3 hours it never finished.

So I tried to create a keypair from terminal using the same backend used by QPass (gpg2); when I type my fullname (I typed "dakk" that's my nickname) gpg2 says that the fullname should be longer than 4 characters.

I figured out that QPass received this error by gpg2, but this error is not handled properly by QPass.

gpg (GnuPG) 2.0.30
libgcrypt 1.7.3
Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, RSA, RSA, ELG, DSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: MD5, SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2

@egilh

This comment has been minimized.

egilh commented Oct 3, 2016

First time qtpass user here.
I can confirm I have the same issue.
Trying to create a keypair, filling in my email and full name, it hangs on "Generating a new keypair".

Adding a letter to my given name makes it possible to create a keypair. Doesn't matter if I also use my surname or not, its the length of the given name that creates the issue.

@annejan

This comment has been minimized.

Member

annejan commented Oct 3, 2016

Solution seems to be two-fold.

A) Correctly check for status / errors of gpg2 keygen.
B) Warn that the "given name" should be longer than 4 characters.

@dakk

This comment has been minimized.

Contributor

dakk commented Oct 3, 2016

I implemented the (B) solution. I also checked for email validity (gpg2 expect for a valid email address)

@annejan annejan changed the title from Short fullname hangs QPass keypair generation process for infinite time to Short fullname hangs QtPass keypair generation process for infinite time Oct 3, 2016

@annejan annejan closed this Oct 12, 2016

annejan added a commit that referenced this issue Oct 12, 2016

TODO added, closing #202
localisation and backlog updated..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment