Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ConfigDialog #235

Closed
annejan opened this issue Nov 23, 2016 · 1 comment
Closed

Clean up ConfigDialog #235

annejan opened this issue Nov 23, 2016 · 1 comment
Assignees
@annejan
Labels
refactoring settings

Comments

@annejan
Copy link
Member

annejan commented Nov 23, 2016

Now that we have a QtPassSettings class since #224, the whole MainWindow => ConfigDialog => MainWindow passing of all the settings is totally unnecessary . .
@annejan annejan self-assigned this Nov 23, 2016
@annejan
Copy link
Member Author

annejan commented Nov 23, 2016 •
edited

Currently working on this in develop branch . .

@annejan annejan mentioned this issue Nov 23, 2016
Closed
@annejan annejan closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annejan annejan

Labels
refactoring settings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annejan