New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ConfigDialog #235

annejan opened this Issue Nov 23, 2016 · 1 comment


1 participant

annejan commented Nov 23, 2016

Now that we have a QtPassSettings class since #224, the whole MainWindow => ConfigDialog => MainWindow passing of all the settings is totally unnecessary . .

@annejan annejan self-assigned this Nov 23, 2016


This comment has been minimized.


annejan commented Nov 23, 2016

Currently working on this in develop branch . .

@annejan annejan closed this Nov 7, 2017

@annejan annejan moved this from In progress to QA in Release 1.2.1 Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment