New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-clicking might open previous entry instead of one double-clicked on #243

Closed
annejan opened this Issue Nov 28, 2016 · 3 comments

Comments

Projects
2 participants
@annejan
Member

annejan commented Nov 28, 2016

  • Click first entry, wait for it to open
  • Double-click on second entry

Current behaviour
First entry data is opened for editing (second entry name is shown as location in dialog title)
When selecting [OK] second entry data is overwritten with (edited) content of first entry
Second entry is shown with overwritten data
When selecting [Cancel] second entry is shown

Expected behaviour
Second entry is opened for editing

Related to #230

@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 10, 2016

@annejan Could you assign it to me?

YoshiMan pushed a commit to YoshiMan/QtPass that referenced this issue Dec 11, 2016

Janosch Knack
executeing pass show before editpassword dialog shows up
Double-clicking might open previous entry instead of one double-clicked on IJHack#243

YoshiMan pushed a commit to YoshiMan/QtPass that referenced this issue Dec 11, 2016

Janosch Knack
executeing pass show before editpassword dialog shows up
Double-clicking might open previous entry instead of one double-clicked on IJHack#243

annejan added a commit that referenced this issue Dec 11, 2016

Merge pull request #254 from YoshiMan/feature/#243
executeing pass show before editpassword dialog shows up
@YoshiMan

This comment has been minimized.

YoshiMan commented Dec 14, 2016

this should be fixed, right?

@annejan

This comment has been minimized.

Member

annejan commented Dec 14, 2016

It should, will test after dinner :)

@annejan annejan closed this Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment