Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-clicking might open previous entry instead of one double-clicked on #243

Closed
annejan opened this issue Nov 28, 2016 · 3 comments
Closed

Double-clicking might open previous entry instead of one double-clicked on #243

annejan opened this issue Nov 28, 2016 · 3 comments
Assignees
@YoshiMan
Labels
regression

Comments

@annejan
Copy link
Member

annejan commented Nov 28, 2016 •
edited

  • Click first entry, wait for it to open
  • Double-click on second entry

Current behaviour
First entry data is opened for editing (second entry name is shown as location in dialog title)
When selecting [OK] second entry data is overwritten with (edited) content of first entry
Second entry is shown with overwritten data
When selecting [Cancel] second entry is shown

Expected behaviour
Second entry is opened for editing

Related to #230
@annejan annejan mentioned this issue Dec 6, 2016
Merged
@YoshiMan
Copy link

@annejan Could you assign it to me?

YoshiMan pushed a commit to YoshiMan/QtPass that referenced this issue Dec 11, 2016
executeing pass show before editpassword dialog shows up
977d5a6 
Double-clicking might open previous entry instead of one double-clicked on IJHack#243
@YoshiMan YoshiMan mentioned this issue Dec 11, 2016
Merged
YoshiMan pushed a commit to YoshiMan/QtPass that referenced this issue Dec 11, 2016
executeing pass show before editpassword dialog shows up
b817f01 
Double-clicking might open previous entry instead of one double-clicked on IJHack#243
annejan added a commit that referenced this issue Dec 11, 2016
@annejan
Merge pull request #254 from YoshiMan/feature/#243
c88b9f2 
executeing pass show before editpassword dialog shows up
@YoshiMan
Copy link

this should be fixed, right?

@annejan
Copy link
Member Author

annejan commented Dec 14, 2016

It should, will test after dinner :)

@annejan annejan closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoshiMan YoshiMan

Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annejan @YoshiMan