/QtPass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: removal of lastDecrypt #256

Closed
YoshiMan opened this Issue Dec 11, 2016 · 2 comments

Comments

Assignees

@tezeb tezeb

Labels
refactoring
Projects
None yet
Milestone
No milestone
3 participants
@YoshiMan @annejan @tezeb
@YoshiMan

YoshiMan commented Dec 11, 2016

The lastDecrypt property is not needed anymore. It should be removed. Could be a bit tricky ;)
@annejan

This comment has been minimized.

Sign in to view
Member

annejan commented Dec 11, 2016

But will make the whole thing more robust by removing this weird "global" that might be filled with secret data 😄

@annejan annejan self-assigned this Dec 11, 2016

@annejan annejan added the refactoring label Dec 11, 2016

@tezeb

This comment has been minimized.

Sign in to view
Contributor

tezeb commented Dec 11, 2016

@annejan you can assign it to me
I think I have it mostly done, but there is few cases that I need to analyze carefully.

@annejan annejan assigned tezeb and unassigned annejan Dec 12, 2016

@annejan annejan closed this Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment