Skip to content

/ QtPass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: removal of lastDecrypt #256

Closed
YoshiMan opened this issue Dec 11, 2016 · 2 comments
Closed

Refactoring: removal of lastDecrypt #256

YoshiMan opened this issue Dec 11, 2016 · 2 comments
Assignees
@tezeb
Labels
refactoring

Comments

@YoshiMan
Copy link

@YoshiMan YoshiMan commented Dec 11, 2016

The lastDecrypt property is not needed anymore. It should be removed. Could be a bit tricky ;)
@annejan
Copy link
Member

@annejan annejan commented Dec 11, 2016

But will make the whole thing more robust by removing this weird "global" that might be filled with secret data 😄
@annejan annejan self-assigned this Dec 11, 2016
@tezeb
Copy link
Contributor

@tezeb tezeb commented Dec 11, 2016

@annejan you can assign it to me
I think I have it mostly done, but there is few cases that I need to analyze carefully.
@annejan annejan assigned tezeb and unassigned annejan Dec 12, 2016
@annejan annejan closed this Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tezeb tezeb

Labels
refactoring
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@annejan @YoshiMan @tezeb