New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Use primary selection instead of clipboard #280

Closed
krayon opened this Issue Jan 18, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@krayon
Contributor

krayon commented Jan 18, 2017

I personally don't use the clipboard all that often but DO use the primary selection quite a bit. An option to choose between them would be nice.

I originally patched v1.0.1 to offer this and have now done so with current master. I have NEVER done any QT development however so it was a copy/paste/search/replace job. I am therefore not creating a PR but you can see it on my branch (f-clipsel) here:
https://github.com/krayon/QtPass/tree/f-clipsel

@krayon

This comment has been minimized.

Contributor

krayon commented Jan 18, 2017

I realise now that it should be disabled in other OS', so will require a platform check in ConfigDialog::on_comboBoxClipboard_activated and MainWindow::copyTextToClipboard (at least).

@annejan annejan self-assigned this Jan 18, 2017

@annejan annejan added the enhancement label Jan 18, 2017

@annejan

This comment has been minimized.

Member

annejan commented Jan 18, 2017

This looks like a great feature.

I would like to try what it does on other OS' and if it doesn't break anything (which I think it won't since it's nicely abstracted away by Qt) keep the change as-is.

@annejan

This comment has been minimized.

Member

annejan commented Jan 18, 2017

I took the Windows build from https://ci.appveyor.com/project/annejan/qtpass/build/1.1.531

Installed on a Windows 7 VM from modern.ie

Primary selection does nothing on Windows (also doesn't break anything) so option should just be disabled. Also found some other UI/UX tweaks needed in Settings screen.

Primary selection works like a charm on macOS and Arch+KDE.

@annejan annejan closed this Jan 18, 2017

@annejan

This comment has been minimized.

Member

annejan commented Jan 18, 2017

Implementing a: QClipboard::supportsSelection() check 👍

@annejan annejan reopened this Jan 18, 2017

@annejan

This comment has been minimized.

Member

annejan commented Jan 18, 2017

The only thing really missing from your PR was the handling of (auto) clearing of selection (switch) clipboard.

@krayon

This comment has been minimized.

Contributor

krayon commented Jan 19, 2017

Wow, quick work, thanks @annejan :D

I think a translation is still needed for other languages (building outputs "Generated 167 translation(s) (166 finished and 1 unfinished)") - sadly I only speak English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment