New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install currently broken. #289

Closed
annejan opened this Issue Feb 2, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@annejan
Member

annejan commented Feb 2, 2017

After moving sources make install seems to not do anything.

@annejan annejan added the regression label Feb 2, 2017

@annejan annejan self-assigned this Feb 2, 2017

@JonasGroeger

This comment has been minimized.

JonasGroeger commented Feb 17, 2017

I'm not knowledgable in Make / QMake expert so I can't provide a pull request for this but here is the output when trying to build the master branch:

$ git clone git@github.com:IJHack/QtPass.git
$ cd QtPass
$ qmake && make && make install
WARNING: Failure to find: src/resources.qrc
cd src/ && /usr/lib/x86_64-linux-gnu/qt4/bin/qmake /tmp/QtPass/src/src.pro -o Makefile
sh: 1: lupdate-qt4: not found
sh: 1: lrelease-qt4: not found
cd src/ && make -f Makefile 
make[1]: Entering directory '/tmp/QtPass/src'
lrelease-qt4 ../localization/localization_nl_NL.ts -qm ../localization/localization_nl_NL.qm
make[1]: lrelease-qt4: Command not found
Makefile:251: recipe for target '../localization/localization_nl_NL.qm' failed
make[1]: *** [../localization/localization_nl_NL.qm] Error 127
make[1]: Leaving directory '/tmp/QtPass/src'
Makefile:39: recipe for target 'sub-src-make_default' failed
make: *** [sub-src-make_default] Error 2

Hope this helps.

@annejan

This comment has been minimized.

Member

annejan commented Feb 17, 2017

In your case the error is caused by two missing applications.

sh: 1: lupdate-qt4: not found
sh: 1: lrelease-qt4: not found

These are part of the qt linguist tools (used for localisation) . .
Also you are attempting to compile QtPass with qt4 . . is there any specific reason you are not using qt5 yet?

@JonasGroeger

This comment has been minimized.

JonasGroeger commented Feb 17, 2017

Nope. I'm trying to build with qt5 but there is no lrelease for it?! See http://packages.ubuntu.com/search?suite=yakkety&arch=any&mode=exactfilename&searchon=contents&keywords=lrelease-qt5

With qmake -qt=qt5 && make && make install it fails with the same error: make[1]: lrelease-qt4: Command not found

Seems like qt4 is required after all?

@annejan

This comment has been minimized.

Member

annejan commented Feb 17, 2017

That's because qt4 is deprecated so it's just called lrelease
http://packages.ubuntu.com/search?mode=exactfilename&suite=yakkety&section=all&arch=any&keywords=lrelease&searchon=contents

Don't have access to an Ubuntu VM to check but I'm pretty sure it should be in the qttools5-dev-tools package.

Perhaps a make clean would help with the qt5 build attempting to use qt4 tooling (or it's fallback behavior).

@annejan

This comment has been minimized.

Member

annejan commented Feb 28, 2017

Fixed in 13bddc5

@annejan annejan closed this Feb 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment