New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config dialog: Propose "Password behaviour" label change #294

Closed
keitalbame opened this Issue Feb 12, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@keitalbame

keitalbame commented Feb 12, 2017

Change Password behaviour label to Content panel behaviour on configdialog.ui since the options below are all related with data shown in the panel.

@annejan annejan added the ui / ux label Feb 13, 2017

@annejan annejan self-assigned this Feb 13, 2017

@keitalbame

This comment has been minimized.

keitalbame commented Feb 16, 2017

Just realized that translations would need to be adjusted after this change.

I have a new translation ready for PR but is not reflecting this change yet.

Should I create the PR for the new language as is and perfom the adjustement later or wait for the change to be completed?

@annejan

This comment has been minimized.

Member

annejan commented Feb 16, 2017

If you are OK with waiting an hour or so, I should be able to have the change in. .

@keitalbame

This comment has been minimized.

keitalbame commented Feb 16, 2017

Sure, no need to hurry :)

@annejan annejan closed this in 44c9c44 Feb 16, 2017

@annejan

This comment has been minimized.

Member

annejan commented Feb 16, 2017

Well, finally have a long weekend to do geeky non-work-related stuff, so best to get a simple issue out of the way first 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment