New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard clearing timer is not reset when new passwords are copied to the clipboard #309

Closed
Thireus opened this Issue Apr 14, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@Thireus

Thireus commented Apr 14, 2017

The timer event for the clipboard clearing functionality should be improved. When new passwords are copied in the clipboard the timer should be reset to the user's time interval set in the settings.

The current behaviour is as such:

The clearing timer starts whenever a 'copy to clipboard' event is detected. However if another 'copy to clipboard' event is detected while the clearing didn't occur yet then the user will have his clipboard (which contains the new copied password) cleared sooner than expected.

PoC:

  1. Set the clearing timer to 10sec.
  2. Click on a password to copy in the clipboard.
  3. Wait 5 seconds.
  4. Click on another password to copy to the clipboard.
  5. Observe that the clipboard is cleared after 5 seconds instead of 10 seconds (because the clearing timer wasn't reset when the second password was copied).
@annejan

This comment has been minimized.

Member

annejan commented May 4, 2017

Sorry, not related to 307

@Thireus

This comment has been minimized.

Thireus commented May 4, 2017

Hi @annejan, these issues are not related. In #307 it's all about the GPG passphrase to decrypt the user's private key. In my issue it's about the QtPass clipboard auto-clear timer.

Maybe I wasn't clear in my initial comment, let me try to rephrase it:

When the auto-clear functionality is set for X seconds, when decrypting a password the clipboard is automatically cleared after X seconds. However, if in the meantime (before the first auto-clear occurs) the user decrypts another password, the first auto-clear will sill clear the clipboard after X seconds based on the first password's decryption date, not based on the second password decryption date. Which means that if you decrypt a second password right before the first auto-clear occurs, your clipboard is going to be immediately cleared when the second password is copied in the clipboard which is kinda annoying.

Is it more clear?

@annejan

This comment has been minimized.

Member

annejan commented May 4, 2017

I'm sorry indeed not related.
Will clear up the misunderstanding..

@annejan annejan added the regression label May 4, 2017

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Mar 30, 2018

I cannot reproduce this with the last version compiled with Qt 5.10 on GNU/Linux. :(

@Thireus

This comment has been minimized.

Thireus commented Mar 30, 2018

The latest version for MacOS works great. I'm not able to reproduce the issue, so I believe it can be closed.

@Thireus Thireus closed this Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment