New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipboard clearing timer is not reset when new passwords are copied to the clipboard #309
Comments
Sorry, not related to |
Hi @annejan, these issues are not related. In #307 it's all about the GPG passphrase to decrypt the user's private key. In my issue it's about the QtPass clipboard auto-clear timer. Maybe I wasn't clear in my initial comment, let me try to rephrase it: When the auto-clear functionality is set for X seconds, when decrypting a password the clipboard is automatically cleared after X seconds. However, if in the meantime (before the first auto-clear occurs) the user decrypts another password, the first auto-clear will sill clear the clipboard after X seconds based on the first password's decryption date, not based on the second password decryption date. Which means that if you decrypt a second password right before the first auto-clear occurs, your clipboard is going to be immediately cleared when the second password is copied in the clipboard which is kinda annoying. Is it more clear? |
I'm sorry indeed not related. |
I cannot reproduce this with the last version compiled with Qt 5.10 on GNU/Linux. :( |
The latest version for MacOS works great. I'm not able to reproduce the issue, so I believe it can be closed. |
The timer event for the clipboard clearing functionality should be improved. When new passwords are copied in the clipboard the timer should be reset to the user's time interval set in the settings.
The current behaviour is as such:
The clearing timer starts whenever a 'copy to clipboard' event is detected. However if another 'copy to clipboard' event is detected while the clearing didn't occur yet then the user will have his clipboard (which contains the new copied password) cleared sooner than expected.
PoC:
The text was updated successfully, but these errors were encountered: